Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/web/WebLocalFrameImpl.cpp

Issue 459633002: Autosizing storage doesnot belong on FrameView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Aligned with review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/FrameViewAutoSizeInfo.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1618 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 1629
1630 ASSERT(frame()); // If frame() doesn't exist, we probably didn't init proper ly. 1630 ASSERT(frame()); // If frame() doesn't exist, we probably didn't init proper ly.
1631 1631
1632 WebViewImpl* webView = viewImpl(); 1632 WebViewImpl* webView = viewImpl();
1633 bool isLocalRoot = frame()->isLocalRoot(); 1633 bool isLocalRoot = frame()->isLocalRoot();
1634 if (isLocalRoot) 1634 if (isLocalRoot)
1635 webView->suppressInvalidations(true); 1635 webView->suppressInvalidations(true);
1636 1636
1637 frame()->createView(webView->size(), webView->baseBackgroundColor(), webView ->isTransparent()); 1637 frame()->createView(webView->size(), webView->baseBackgroundColor(), webView ->isTransparent());
1638 if (webView->shouldAutoResize() && isLocalRoot) 1638 if (webView->shouldAutoResize() && isLocalRoot)
1639 frame()->view()->enableAutoSizeMode(true, webView->minAutoSize(), webVie w->maxAutoSize()); 1639 frame()->view()->enableAutoSizeMode(webView->minAutoSize(), webView->max AutoSize());
1640 1640
1641 frame()->view()->setInputEventsTransformForEmulation(m_inputEventsOffsetForE mulation, m_inputEventsScaleFactorForEmulation); 1641 frame()->view()->setInputEventsTransformForEmulation(m_inputEventsOffsetForE mulation, m_inputEventsScaleFactorForEmulation);
1642 1642
1643 if (isLocalRoot) 1643 if (isLocalRoot)
1644 webView->suppressInvalidations(false); 1644 webView->suppressInvalidations(false);
1645 } 1645 }
1646 1646
1647 WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame* frame) 1647 WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame* frame)
1648 { 1648 {
1649 if (!frame) 1649 if (!frame)
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1867 1867
1868 void WebLocalFrameImpl::invalidateAll() const 1868 void WebLocalFrameImpl::invalidateAll() const
1869 { 1869 {
1870 ASSERT(frame() && frame()->view()); 1870 ASSERT(frame() && frame()->view());
1871 FrameView* view = frame()->view(); 1871 FrameView* view = frame()->view();
1872 view->invalidateRect(view->frameRect()); 1872 view->invalidateRect(view->frameRect());
1873 invalidateScrollbar(); 1873 invalidateScrollbar();
1874 } 1874 }
1875 1875
1876 } // namespace blink 1876 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/FrameViewAutoSizeInfo.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698