Issue 459623002: Fix GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459623002: Fix GN build. (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev, Michael Achenbach

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix GN build. TBR=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23013

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

This mirrors this change to v8.gyp: https://codereview.chromium.org/455743002/diff/1/tools/gyp/v8.gyp symbol.js is required for array.js, hence the move.

6 years, 4 months ago (2014-08-09 10:02:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as 23013 (tree was closed).

Expand Messages | Collapse Messages