Issue 459613009: Convert IPC::ChannelMojo initialization to use new mojo::embedder::CreateChannelOnIOThread().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459613009: Convert IPC::ChannelMojo initialization to use new mojo::embedder::CreateChannelOnIOThread(). (Closed)

Created:
6 years, 4 months ago by viettrungluu

Modified:
6 years, 4 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert IPC::ChannelMojo initialization to use new mojo::embedder::CreateChannelOnIOThread(). (Also simplify things a bit.) R=morrita@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289071

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -40 lines)			Patch
	M	ipc/mojo/ipc_channel_mojo.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	ipc/mojo/ipc_channel_mojo.cc	View		4 chunks	+24 lines, -36 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Hajime Morrita

On 2014/08/12 17:40:29, viettrungluu wrote: LGTM. Thanks for the refactoring! This might fix https://crbug.com/402333 as ...

6 years, 4 months ago (2014-08-12 17:47:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/459613009/1

6 years, 4 months ago (2014-08-12 17:48:50 UTC) #4

viettrungluu

Committed patchset #1 manually as 289071 (presubmit successful).

6 years, 4 months ago (2014-08-12 21:44:34 UTC) #5

viettrungluu

6 years, 4 months ago (2014-08-12 21:45:23 UTC) #6

Message was sent while issue was closed.

On 2014/08/12 17:47:24, morrita wrote:
> On 2014/08/12 17:40:29, viettrungluu wrote:
> 
> LGTM. Thanks for the refactoring!
> This might fix https://crbug.com/402333 as it turns a raw pointer to a weak
ptr?

Maybe? (Or maybe not?) I'm not sure. It's not obvious to me that it'd fix it,
but the reason behind that crash isn't obvious to me either. ;)

Expand Messages | Collapse Messages