Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: athena/wm/window_manager_impl.cc

Issue 459613008: athena: Allow getting into split-view mode from overview-mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index f6488e395c14a5790d898a6e001444a2116d5300..4a60767ad2e60dd2d434eba0ed2a587e69a3a724 100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -58,6 +58,8 @@ class WindowManagerImpl : public WindowManager,
// WindowOverviewModeDelegate:
virtual void OnSelectWindow(aura::Window* window) OVERRIDE;
+ virtual void OnSplitViewMode(aura::Window* left,
+ aura::Window* right) OVERRIDE;
// aura::WindowObserver
virtual void OnWindowAdded(aura::Window* new_window) OVERRIDE;
@@ -206,6 +208,12 @@ void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
SetInOverview(false);
}
+void WindowManagerImpl::OnSplitViewMode(aura::Window* left,
+ aura::Window* right) {
+ SetInOverview(false);
mfomitchev 2014/08/13 15:12:31 Hmm.. my understanding from the mocks was that you
sadrul 2014/08/13 16:20:12 We are going with this for now. I clarified with k
mfomitchev 2014/08/13 17:42:52 I thought it was a bit ambiguous, so I responded o
+ split_view_controller_->ActivateSplitMode(left, right);
+}
+
void WindowManagerImpl::OnWindowAdded(aura::Window* new_window) {
if (new_window->type() == ui::wm::WINDOW_TYPE_NORMAL)
SetInOverview(false);

Powered by Google App Engine
This is Rietveld 408576698