Cleanup: Remove unneeded SSE2 checks and unused code.

Cleanup: Remove unneeded SSE2 checks and unused code.

BUG=349320
Committed: https://crrev.com/17e71b798adba6be1c3c96df6f891e730e8a89f9
Cr-Commit-Position: refs/heads/master@{#292100}

[Lei Zhang, 2014-08-12 05:53:30]

cpu: Please take an initial look.

[DaleCurtis, 2014-08-12 17:01:11]

https://codereview.chromium.org/459603003/diff/20001/media/base/yuv_convert.cc
File media/base/yuv_convert.cc (right):

https://codereview.chromium.org/459603003/diff/20001/media/base/yuv_convert.c...
media/base/yuv_convert.cc:167: base::CPU cpu;
Move this to the ssse3 check below.

https://codereview.chromium.org/459603003/diff/20001/media/base/yuv_convert.c...
media/base/yuv_convert.cc:169: g_convert_yuva_to_argb_proc_ =
ConvertYUVAToARGB_MMX;
We should probably benchmark these YUV methods to see if the auto-vectorized
SSE2 version of the C code is faster.  I know rileya@ was looking at replacing
all of this with libyuv... +rileya

[cpu_(ooo_6.6-7.5), 2014-08-13 23:24:42]

lgtm

Just in case I don't catch it, the installer does need to keep the check. That
file I don't see in this review so we are good.

I skipped a few media files.

https://codereview.chromium.org/459603003/diff/20001/media/base/BUILD.gn
File media/base/BUILD.gn (left):

https://codereview.chromium.org/459603003/diff/20001/media/base/BUILD.gn#oldc...
media/base/BUILD.gn:373: "simd/convert_yuv_to_rgb_sse.asm",
only that one?

[Lei Zhang, 2014-08-20 23:30:33]

Riley, care to comment on this? Alternatively, I can remove media/ from this CL
and you guys can work on it separately.

[Lei Zhang, 2014-08-20 23:31:49]

+senorblanco for skia

[rileya (GONE FROM CHROMIUM), 2014-08-20 23:40:48]

Sorry for the delay! Was out a bunch last week.

> We should probably benchmark these YUV methods to see if the auto-vectorized
SSE2 version of the C code is faster.  I know rileya@ was looking at replacing
all of this with libyuv... +rileya

Most of this has been replaced with libyuv already actually, but there remain a
few edge cases where media/base/simd is used (namely YUVA and YUVJ).

In the future all of the media/ YUV SIMD stuff should just be killed off
completely imo, but that's going to require libyuv changes, among other things.
So this CL looks fine for now.

media/ LGTM (non-OWNER)

[DaleCurtis, 2014-08-21 00:34:27]

lgtm

[Lei Zhang, 2014-08-26 07:25:06]

On 2014/08/20 23:31:49, Lei Zhang wrote:
> +senorblanco for skia

ping

[Stephen White, 2014-08-26 12:16:50]

LGTM

[Lei Zhang, 2014-08-26 19:39:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-26 19:41:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/459603003/40001

[commit-bot: I haz the power, 2014-08-26 19:54:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46522)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/51884)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 19:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 19:56:24]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46528)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Lei Zhang, 2014-08-26 20:37:26]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-26 20:39:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/459603003/60001

[commit-bot: I haz the power, 2014-08-27 02:32:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/51926)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 02:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 02:35:34]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lei Zhang, 2014-08-27 02:44:22]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-27 02:44:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/459603003/80001

[commit-bot: I haz the power, 2014-08-27 04:41:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-27 05:24:08]

Committed patchset #4 (80001) as b2cd99b39c3744f61231f8818f6c7a3d2881f0f0

[Lei Zhang, 2014-08-27 06:32:55]

A revert of this CL (patchset #4) has been created in
https://codereview.chromium.org/513663002/ by thestig@chromium.org.

The reason for reverting is: Passed the win x64 trybot, but failed on the win 64
builder..

[Lei Zhang, 2014-08-27 06:42:15]

On 2014/08/27 06:32:55, Lei Zhang wrote:
> A revert of this CL (patchset #4) has been created in
> https://codereview.chromium.org/513663002/ by mailto:thestig@chromium.org.
> 
> The reason for reverting is: Passed the win x64 trybot, but failed on the win
64
> builder..

I will resubmit this CL sans media/ changes. I filed https://crbug.com/407989
for the build failure.

[commit-bot: I haz the power, 2014-09-10 02:49:49]

Patchset 4 (id:??) landed as
https://crrev.com/17e71b798adba6be1c3c96df6f891e730e8a89f9
Cr-Commit-Position: refs/heads/master@{#292100}