Issue 459603002: Remove RenderFlowThread::adjustedPositionRelativeToOffsetParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459603002: Remove RenderFlowThread::adjustedPositionRelativeToOffsetParent (Closed)

Created:
6 years, 4 months ago by pdr.

Modified:
6 years, 4 months ago

Reviewers:
rune, eseidel

CC:
blink-reviews, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove RenderFlowThread::adjustedPositionRelativeToOffsetParent This patch removes RenderFlowThread::adjustedPositionRelativeToOffsetParent which was added in [1] to support regions. This code is no longer called and is dead. [1] https://src.chromium.org/viewvc/blink?view=rev&revision=150894 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179895

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -79 lines)			Patch
	M	Source/core/rendering/RenderFlowThread.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/rendering/RenderFlowThread.cpp	View		2 chunks	+0 lines, -77 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rune

There are no open CLs from mstensho which starts using it again, so LGTM.

6 years, 4 months ago (2014-08-10 16:49:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/459603002/1

6 years, 4 months ago (2014-08-10 16:55:10 UTC) #4

Message was sent while issue was closed.

Change committed as 179895

Expand Messages | Collapse Messages