Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3356)

Unified Diff: content/renderer/pepper/v8_var_converter.h

Issue 459553003: Replace NPObject usage in ppapi with gin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/ppb_var_deprecated_impl.cc ('k') | content/renderer/pepper/v8_var_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/v8_var_converter.h
diff --git a/content/renderer/pepper/v8_var_converter.h b/content/renderer/pepper/v8_var_converter.h
index e6206cd95820497506b08f122a9726da684f924f..77687e464f78783ca5d543049e609e65143f0ffb 100644
--- a/content/renderer/pepper/v8_var_converter.h
+++ b/content/renderer/pepper/v8_var_converter.h
@@ -21,8 +21,14 @@ class ResourceConverter;
class CONTENT_EXPORT V8VarConverter {
public:
+ // Whether or not to allow converting object vars. If they are not allowed
+ // and they are passed in, conversion will fail.
+ enum AllowObjectVars {
+ kDisallowObjectVars,
+ kAllowObjectVars
+ };
explicit V8VarConverter(PP_Instance instance);
- V8VarConverter(PP_Instance instance, bool object_vars_allowed);
+ V8VarConverter(PP_Instance instance, AllowObjectVars object_vars_allowed);
// Constructor for testing.
V8VarConverter(PP_Instance instance,
@@ -76,7 +82,7 @@ class CONTENT_EXPORT V8VarConverter {
PP_Instance instance_;
// Whether or not to support conversion to PP_VARTYPE_OBJECT.
- bool object_vars_allowed_;
+ AllowObjectVars object_vars_allowed_;
// The message loop to run the callback to |FromV8Value| from.
scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
« no previous file with comments | « content/renderer/pepper/ppb_var_deprecated_impl.cc ('k') | content/renderer/pepper/v8_var_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698