Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: content/renderer/pepper/host_var_tracker.cc

Issue 459553003: Replace NPObject usage in ppapi with gin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/pepper/host_var_tracker.h" 5 #include "content/renderer/pepper/host_var_tracker.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/renderer/pepper/host_array_buffer_var.h" 8 #include "content/renderer/pepper/host_array_buffer_var.h"
9 #include "content/renderer/pepper/host_globals.h"
9 #include "content/renderer/pepper/host_resource_var.h" 10 #include "content/renderer/pepper/host_resource_var.h"
10 #include "content/renderer/pepper/npobject_var.h"
11 #include "content/renderer/pepper/pepper_plugin_instance_impl.h" 11 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
12 #include "content/renderer/pepper/v8object_var.h"
12 #include "ppapi/c/pp_var.h" 13 #include "ppapi/c/pp_var.h"
13 14
14 using ppapi::ArrayBufferVar; 15 using ppapi::ArrayBufferVar;
15 using ppapi::NPObjectVar; 16 using ppapi::V8ObjectVar;
16 17
17 namespace content { 18 namespace content {
18 19
20 HostVarTracker::V8ObjectVarKey::V8ObjectVarKey(V8ObjectVar* object_var)
21 : instance(object_var->instance()->pp_instance()) {
22 v8::Local<v8::Object> object = object_var->GetHandle();
23 hash = object.IsEmpty() ? 0 : object->GetIdentityHash();
24 }
25
26 HostVarTracker::V8ObjectVarKey::V8ObjectVarKey(PP_Instance instance,
27 v8::Handle<v8::Object> object)
28 : instance(instance),
29 hash(object.IsEmpty() ? 0 : object->GetIdentityHash()) {}
30
31 HostVarTracker::V8ObjectVarKey::~V8ObjectVarKey() {}
32
33 bool HostVarTracker::V8ObjectVarKey::operator<(
34 const V8ObjectVarKey& other) const {
35 if (instance == other.instance)
36 return hash < other.hash;
37 return instance < other.instance;
38 }
39
19 HostVarTracker::HostVarTracker() 40 HostVarTracker::HostVarTracker()
20 : VarTracker(SINGLE_THREADED), last_shared_memory_map_id_(0) {} 41 : VarTracker(SINGLE_THREADED), last_shared_memory_map_id_(0) {}
21 42
22 HostVarTracker::~HostVarTracker() {} 43 HostVarTracker::~HostVarTracker() {}
23 44
24 ArrayBufferVar* HostVarTracker::CreateArrayBuffer(uint32 size_in_bytes) { 45 ArrayBufferVar* HostVarTracker::CreateArrayBuffer(uint32 size_in_bytes) {
25 return new HostArrayBufferVar(size_in_bytes); 46 return new HostArrayBufferVar(size_in_bytes);
26 } 47 }
27 48
28 ArrayBufferVar* HostVarTracker::CreateShmArrayBuffer( 49 ArrayBufferVar* HostVarTracker::CreateShmArrayBuffer(
29 uint32 size_in_bytes, 50 uint32 size_in_bytes,
30 base::SharedMemoryHandle handle) { 51 base::SharedMemoryHandle handle) {
31 return new HostArrayBufferVar(size_in_bytes, handle); 52 return new HostArrayBufferVar(size_in_bytes, handle);
32 } 53 }
33 54
34 void HostVarTracker::AddNPObjectVar(NPObjectVar* object_var) { 55 void HostVarTracker::AddV8ObjectVar(V8ObjectVar* object_var) {
35 CheckThreadingPreconditions(); 56 CheckThreadingPreconditions();
36 57 v8::HandleScope handle_scope(object_var->instance()->GetIsolate());
37 InstanceMap::iterator found_instance = 58 DCHECK(GetForV8Object(object_var->instance()->pp_instance(),
38 instance_map_.find(object_var->pp_instance()); 59 object_var->GetHandle()) == object_map_.end());
39 if (found_instance == instance_map_.end()) { 60 object_map_.insert(std::make_pair(V8ObjectVarKey(object_var), object_var));
40 // Lazily create the instance map.
41 DCHECK(object_var->pp_instance() != 0);
42 found_instance =
43 instance_map_.insert(std::make_pair(
44 object_var->pp_instance(),
45 linked_ptr<NPObjectToNPObjectVarMap>(
46 new NPObjectToNPObjectVarMap))).first;
47 }
48 NPObjectToNPObjectVarMap* np_object_map = found_instance->second.get();
49
50 DCHECK(np_object_map->find(object_var->np_object()) == np_object_map->end())
51 << "NPObjectVar already in map";
52 np_object_map->insert(std::make_pair(object_var->np_object(), object_var));
53 } 61 }
54 62
55 void HostVarTracker::RemoveNPObjectVar(NPObjectVar* object_var) { 63 void HostVarTracker::RemoveV8ObjectVar(V8ObjectVar* object_var) {
56 CheckThreadingPreconditions(); 64 CheckThreadingPreconditions();
57 65 v8::HandleScope handle_scope(object_var->instance()->GetIsolate());
58 InstanceMap::iterator found_instance = 66 ObjectMap::iterator it = GetForV8Object(
59 instance_map_.find(object_var->pp_instance()); 67 object_var->instance()->pp_instance(), object_var->GetHandle());
60 if (found_instance == instance_map_.end()) { 68 DCHECK(it != object_map_.end());
61 NOTREACHED() << "NPObjectVar has invalid instance."; 69 object_map_.erase(it);
62 return;
63 }
64 NPObjectToNPObjectVarMap* np_object_map = found_instance->second.get();
65
66 NPObjectToNPObjectVarMap::iterator found_object =
67 np_object_map->find(object_var->np_object());
68 if (found_object == np_object_map->end()) {
69 NOTREACHED() << "NPObjectVar not registered.";
70 return;
71 }
72 if (found_object->second != object_var) {
73 NOTREACHED() << "NPObjectVar doesn't match.";
74 return;
75 }
76 np_object_map->erase(found_object);
77 } 70 }
78 71
79 NPObjectVar* HostVarTracker::NPObjectVarForNPObject(PP_Instance instance, 72 PP_Var HostVarTracker::V8ObjectVarForV8Object(PP_Instance instance,
80 NPObject* np_object) { 73 v8::Handle<v8::Object> object) {
81 CheckThreadingPreconditions(); 74 CheckThreadingPreconditions();
82 75 ObjectMap::const_iterator it = GetForV8Object(instance, object);
83 InstanceMap::iterator found_instance = instance_map_.find(instance); 76 if (it == object_map_.end())
84 if (found_instance == instance_map_.end()) 77 return (new V8ObjectVar(instance, object))->GetPPVar();
85 return NULL; // No such instance. 78 return it->second->GetPPVar();
86 NPObjectToNPObjectVarMap* np_object_map = found_instance->second.get();
87
88 NPObjectToNPObjectVarMap::iterator found_object =
89 np_object_map->find(np_object);
90 if (found_object == np_object_map->end())
91 return NULL; // No such object.
92 return found_object->second;
93 } 79 }
94 80
95 int HostVarTracker::GetLiveNPObjectVarsForInstance(PP_Instance instance) const { 81 int HostVarTracker::GetLiveV8ObjectVarsForTest(PP_Instance instance) {
96 CheckThreadingPreconditions(); 82 CheckThreadingPreconditions();
97 83 int count = 0;
98 InstanceMap::const_iterator found = instance_map_.find(instance); 84 // Use a key with an empty handle to find the v8 object var in the map with
99 if (found == instance_map_.end()) 85 // the given instance and the lowest hash.
100 return 0; 86 V8ObjectVarKey key(instance, v8::Handle<v8::Object>());
101 return static_cast<int>(found->second->size()); 87 ObjectMap::const_iterator it = object_map_.lower_bound(key);
88 while (it != object_map_.end() && it->first.instance == instance) {
89 ++count;
90 ++it;
91 }
92 return count;
102 } 93 }
103 94
104 PP_Var HostVarTracker::MakeResourcePPVarFromMessage( 95 PP_Var HostVarTracker::MakeResourcePPVarFromMessage(
105 PP_Instance instance, 96 PP_Instance instance,
106 const IPC::Message& creation_message, 97 const IPC::Message& creation_message,
107 int pending_renderer_id, 98 int pending_renderer_id,
108 int pending_browser_id) { 99 int pending_browser_id) {
109 // On the host side, the creation message is ignored when creating a resource. 100 // On the host side, the creation message is ignored when creating a resource.
110 // Therefore, a call to this function indicates a null resource. Return the 101 // Therefore, a call to this function indicates a null resource. Return the
111 // resource 0. 102 // resource 0.
112 return MakeResourcePPVar(0); 103 return MakeResourcePPVar(0);
113 } 104 }
114 105
115 ppapi::ResourceVar* HostVarTracker::MakeResourceVar(PP_Resource pp_resource) { 106 ppapi::ResourceVar* HostVarTracker::MakeResourceVar(PP_Resource pp_resource) {
116 return new HostResourceVar(pp_resource); 107 return new HostResourceVar(pp_resource);
117 } 108 }
118 109
119 void HostVarTracker::DidDeleteInstance(PP_Instance instance) { 110 void HostVarTracker::DidDeleteInstance(PP_Instance pp_instance) {
120 CheckThreadingPreconditions(); 111 CheckThreadingPreconditions();
121 112
122 InstanceMap::iterator found_instance = instance_map_.find(instance); 113 PepperPluginInstanceImpl* instance =
123 if (found_instance == instance_map_.end()) 114 HostGlobals::Get()->GetInstance(pp_instance);
124 return; // Nothing to do. 115 v8::HandleScope handle_scope(instance->GetIsolate());
125 NPObjectToNPObjectVarMap* np_object_map = found_instance->second.get(); 116 // Force delete all var references. ForceReleaseV8Object() will cause
117 // this object, and potentially others it references, to be removed from
118 // |live_vars_|.
126 119
127 // Force delete all var references. ForceReleaseNPObject() will cause 120 // Use a key with an empty handle to find the v8 object var in the map with
128 // this object, and potentially others it references, to be removed from 121 // the given instance and the lowest hash.
129 // |np_object_map|. 122 V8ObjectVarKey key(pp_instance, v8::Handle<v8::Object>());
130 while (!np_object_map->empty()) { 123 ObjectMap::iterator it = object_map_.lower_bound(key);
131 ForceReleaseNPObject(np_object_map->begin()->second); 124 while (it != object_map_.end() && it->first.instance == pp_instance) {
125 ForceReleaseV8Object(it->second);
126 object_map_.erase(it++);
132 } 127 }
133
134 // Remove the record for this instance since it should be empty.
135 DCHECK(np_object_map->empty());
136 instance_map_.erase(found_instance);
137 } 128 }
138 129
139 void HostVarTracker::ForceReleaseNPObject(ppapi::NPObjectVar* object_var) { 130 void HostVarTracker::ForceReleaseV8Object(ppapi::V8ObjectVar* object_var) {
140 object_var->InstanceDeleted(); 131 object_var->InstanceDeleted();
141 VarMap::iterator iter = live_vars_.find(object_var->GetExistingVarID()); 132 VarMap::iterator iter = live_vars_.find(object_var->GetExistingVarID());
142 if (iter == live_vars_.end()) { 133 if (iter == live_vars_.end()) {
143 NOTREACHED(); 134 NOTREACHED();
144 return; 135 return;
145 } 136 }
146 iter->second.ref_count = 0; 137 iter->second.ref_count = 0;
147 DCHECK(iter->second.track_with_no_reference_count == 0); 138 DCHECK(iter->second.track_with_no_reference_count == 0);
148 DeleteObjectInfoIfNecessary(iter); 139 DeleteObjectInfoIfNecessary(iter);
149 } 140 }
150 141
142 HostVarTracker::ObjectMap::iterator HostVarTracker::GetForV8Object(
143 PP_Instance instance,
144 v8::Handle<v8::Object> object) {
145 std::pair<ObjectMap::iterator, ObjectMap::iterator> range =
146 object_map_.equal_range(V8ObjectVarKey(instance, object));
147
148 for (ObjectMap::iterator it = range.first; it != range.second; ++it) {
149 if (object == it->second->GetHandle())
150 return it;
151 }
152 return object_map_.end();
153 }
154
151 int HostVarTracker::TrackSharedMemoryHandle(PP_Instance instance, 155 int HostVarTracker::TrackSharedMemoryHandle(PP_Instance instance,
152 base::SharedMemoryHandle handle, 156 base::SharedMemoryHandle handle,
153 uint32 size_in_bytes) { 157 uint32 size_in_bytes) {
154 SharedMemoryMapEntry entry; 158 SharedMemoryMapEntry entry;
155 entry.instance = instance; 159 entry.instance = instance;
156 entry.handle = handle; 160 entry.handle = handle;
157 entry.size_in_bytes = size_in_bytes; 161 entry.size_in_bytes = size_in_bytes;
158 162
159 // Find a free id for our map. 163 // Find a free id for our map.
160 while (shared_memory_map_.find(last_shared_memory_map_id_) != 164 while (shared_memory_map_.find(last_shared_memory_map_id_) !=
(...skipping 15 matching lines...) Expand all
176 if (it->second.instance != instance) 180 if (it->second.instance != instance)
177 return false; 181 return false;
178 182
179 *handle = it->second.handle; 183 *handle = it->second.handle;
180 *size_in_bytes = it->second.size_in_bytes; 184 *size_in_bytes = it->second.size_in_bytes;
181 shared_memory_map_.erase(it); 185 shared_memory_map_.erase(it);
182 return true; 186 return true;
183 } 187 }
184 188
185 } // namespace content 189 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/host_var_tracker.h ('k') | content/renderer/pepper/host_var_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698