components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java - Issue 459513002: Massive refactor of the Android invalidation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java

Issue 459513002: Massive refactor of the Android invalidation code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/invalidation/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java ('K') | « components/invalidation/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java ('k') | components/invalidation/invalidation_service_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java

diff --git a/sync/android/javatests/src/org/chromium/sync/notifier/TestableInvalidationService.java b/components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java

similarity index 93%

rename from sync/android/javatests/src/org/chromium/sync/notifier/TestableInvalidationService.java

rename to components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java

index dd4a9320449654636e407ac2ecd3a29f44e64a40..43817f64d6a8f339307873aaad3d5a0badd5068e 100644

--- a/sync/android/javatests/src/org/chromium/sync/notifier/TestableInvalidationService.java

+++ b/components/invalidation/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationService.java

@@ -19,12 +19,12 @@ import java.util.List;

import java.util.Set;

/**

- * Subclass of {@link InvalidationService} that captures events and allows controlling

+ * Subclass of {@link InvalidationClientService} that captures events and allows controlling

* whether or not Chrome is in the foreground and sync is enabled.

* @author dsmyers@google.com (Daniel Myers)

-public class TestableInvalidationService extends InvalidationService {

+public class TestableInvalidationClientService extends InvalidationClientService {

nyquist 2014/09/10 18:25:04 rename file to this new name.

maxbogue 2014/09/11 20:08:09 Done.

/** Object ids given to {@link #register}, one list element per call. */

final List<List<ObjectId>> mRegistrations = new ArrayList<List<ObjectId>>();

@@ -51,7 +51,7 @@ public class TestableInvalidationService extends InvalidationService {

/** Whether sync is enabled. */

private boolean mIsSyncEnabled = false;

- public TestableInvalidationService() {

+ public TestableInvalidationClientService() {

}

@Override