chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java - Issue 459513002: Massive refactor of the Android invalidation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java

Issue 459513002: Massive refactor of the Android invalidation code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationServiceFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java » ('j') | components/invalidation.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java

index c9f092ca997664f289556e9ed4c51760ec6401a1..1a05858b2af946d15037fa5b0b42d8d4c5721e43 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java

@@ -19,6 +19,8 @@ import com.google.protos.ipc.invalidation.Types;

import org.chromium.base.ThreadUtils;

import org.chromium.base.library_loader.ProcessInitException;

+import org.chromium.chrome.browser.invalidation.InvalidationServiceFactory;

+import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.content.browser.BrowserStartupController;

import java.util.concurrent.Semaphore;

@@ -168,12 +170,13 @@ public abstract class ChromiumSyncAdapter extends AbstractThreadedSyncAdapter {

@VisibleForTesting

public void requestSync(int objectSource, String objectId, long version, String payload) {

- ProfileSyncService.get(mApplication)

+ InvalidationServiceFactory.getForProfile(Profile.getLastUsedProfile())

.requestSyncFromNativeChrome(objectSource, objectId, version, payload);

}

@VisibleForTesting

public void requestSyncForAllTypes() {

- ProfileSyncService.get(mApplication).requestSyncFromNativeChromeForAllTypes();

+ InvalidationServiceFactory.getForProfile(Profile.getLastUsedProfile())

+ .requestSyncFromNativeChromeForAllTypes();

}