Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5180)

Unified Diff: chrome/browser/sync/profile_sync_service_android.cc

Issue 459513002: Massive refactor of the Android invalidation code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_android.cc
diff --git a/chrome/browser/sync/profile_sync_service_android.cc b/chrome/browser/sync/profile_sync_service_android.cc
index 567297cc9c73ec7f3cee65a6117d4c43ed2b2733..2af57624992ee97f5ab8bff98c8485aa1225ff23 100644
--- a/chrome/browser/sync/profile_sync_service_android.cc
+++ b/chrome/browser/sync/profile_sync_service_android.cc
@@ -92,42 +92,6 @@ ProfileSyncServiceAndroid::~ProfileSyncServiceAndroid() {
RemoveObserver();
}
-void ProfileSyncServiceAndroid::SendNudgeNotification(
- int object_source,
- const std::string& str_object_id,
- int64 version,
- const std::string& state) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
- // TODO(nileshagrawal): Merge this with ChromeInvalidationClient::Invalidate.
- // Construct the ModelTypeStateMap and send it over with the notification.
- invalidation::ObjectId object_id(
- object_source,
- str_object_id);
- syncer::ObjectIdInvalidationMap object_ids_with_states;
- if (version == ipc::invalidation::Constants::UNKNOWN) {
- object_ids_with_states.Insert(
- syncer::Invalidation::InitUnknownVersion(object_id));
- } else {
- ObjectIdVersionMap::iterator it =
- max_invalidation_versions_.find(object_id);
- if ((it != max_invalidation_versions_.end()) &&
- (version <= it->second)) {
- DVLOG(1) << "Dropping redundant invalidation with version " << version;
- return;
- }
- max_invalidation_versions_[object_id] = version;
- object_ids_with_states.Insert(
- syncer::Invalidation::Init(object_id, version, state));
- }
-
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_SYNC_REFRESH_REMOTE,
- content::Source<Profile>(profile_),
- content::Details<const syncer::ObjectIdInvalidationMap>(
- &object_ids_with_states));
-}
-
void ProfileSyncServiceAndroid::OnStateChanged() {
// Notify the java world that our sync state has changed.
JNIEnv* env = AttachCurrentThread();
@@ -504,28 +468,6 @@ std::string ProfileSyncServiceAndroid::ModelTypeSelectionToStringForTest(
return ConvertJavaStringToUTF8(string);
}
-void ProfileSyncServiceAndroid::NudgeSyncer(JNIEnv* env,
- jobject obj,
- jint objectSource,
- jstring objectId,
- jlong version,
- jstring state) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- SendNudgeNotification(objectSource, ConvertJavaStringToUTF8(env, objectId),
- version, ConvertJavaStringToUTF8(env, state));
-}
-
-void ProfileSyncServiceAndroid::NudgeSyncerForAllTypes(JNIEnv* env,
- jobject obj) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- syncer::ObjectIdInvalidationMap object_ids_with_states;
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_SYNC_REFRESH_REMOTE,
- content::Source<Profile>(profile_),
- content::Details<const syncer::ObjectIdInvalidationMap>(
- &object_ids_with_states));
-}
-
// static
ProfileSyncServiceAndroid*
ProfileSyncServiceAndroid::GetProfileSyncServiceAndroid() {

Powered by Google App Engine
This is Rietveld 408576698