Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html

Issue 459463003: Convert moar Sheriff-o-Matic tests to Polymer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: forgot to add lib/network-simulator.html Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html b/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
index 102145be180dc97e60c2a93e71f92fd9b20e7c6c..26ac18ac6531389358541708e02f52e59048e541 100644
--- a/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
@@ -12,57 +12,32 @@ found in the LICENSE file.
var assert = chai.assert;
describe('ct-embedded-flakiness-dashboard', function() {
- var embeddedFlakinessDashboard;
-
- describe('embedded flakiness dashboard UI', function() {
- var oldUrlForEmbeddedFlakinessDashboard = ui.urlForEmbeddedFlakinessDashboard;
- var testName;
- var step;
- var tree;
-
- beforeEach(function(done) {
- ui.urlForEmbeddedFlakinessDashboard = function(test, step, tree) { return "about:blank#" + test + step + tree; }
- embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
- testName = "foo/bar.html";
- step = "foo_tests";
- tree = "blink";
- embeddedFlakinessDashboard.test = {
- testName: testName,
- step: step,
- };
- embeddedFlakinessDashboard.tree = tree;
-
- setTimeout(done);
- });
-
- afterEach(function() {
- ui.urlForEmbeddedFlakinessDashboard = oldUrlForEmbeddedFlakinessDashboard;
- });
-
- it('should point the iframe to the dashboard', function() {
+ it('should point the iframe to the dashboard', function(done) {
+ var failure = new CTFailure('foo_tests', 'foo/bar.html');
+ var tree = "blink";
+ var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
+ embeddedFlakinessDashboard.test = failure;
+ embeddedFlakinessDashboard.tree = tree;
+
+ setTimeout(function() {
var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
- assert.equal(iframe.src, ui.urlForEmbeddedFlakinessDashboard(testName, step, tree));
+ assert.equal(iframe.src, failure.embeddedFlakinessDashboardURL(tree));
+ done();
});
});
- describe('heightChanged', function() {
- beforeEach(function(done) {
- embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
-
- setTimeout(done);
- });
+ it('should respond to heightChanged', function(done) {
+ var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
- it('should resize the iframe', function(done) {
- var finishTest = function() {
- window.removeEventListener('message', finishTest);
- var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
- assert.equal(iframe.style.height, '100px');
- done();
- };
+ var finishTest = function() {
+ window.removeEventListener('message', finishTest);
+ var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
+ assert.equal(iframe.style.height, '100px');
+ done();
+ };
- window.addEventListener('message', finishTest);
- window.postMessage({command: 'heightChanged', height: "100"}, '*');
- });
+ window.addEventListener('message', finishTest);
+ window.postMessage({command: 'heightChanged', height: "100"}, '*');
});
});
« no previous file with comments | « Tools/GardeningServer/ui/test/ct-builder-grid-tests.html ('k') | Tools/GardeningServer/ui/test/ct-party-time-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698