Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 459463003: Convert moar Sheriff-o-Matic tests to Polymer. (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, Dirk Pranke, dsinclair, dstockwell, leviw_travelin_and_unemployed, szager1
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : forgot to add lib/network-simulator.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -780 lines) Patch
M Tools/GardeningServer/karma.conf.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + Tools/GardeningServer/lib/network-simulator.html View 1 2 1 chunk +62 lines, -40 lines 0 comments Download
M Tools/GardeningServer/model/tree-status-tests.html View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/run-unittests.html View 1 1 chunk +1 line, -11 lines 0 comments Download
M Tools/GardeningServer/scripts/net_unittests.js View 1 1 chunk +0 lines, -79 lines 0 comments Download
A + Tools/GardeningServer/scripts/network-simulator.html View 1 1 chunk +62 lines, -40 lines 0 comments Download
M Tools/GardeningServer/scripts/results_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + Tools/GardeningServer/test/karma-loader.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D Tools/GardeningServer/test/karma_loader.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
M Tools/GardeningServer/test/run-unit-tests.html View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Tools/GardeningServer/test/unit-tests.html View 1 chunk +4 lines, -1 line 0 comments Download
D Tools/GardeningServer/ui/ct-party-time-tests.html View 1 chunk +0 lines, -46 lines 0 comments Download
D Tools/GardeningServer/ui/ct-results-by-builder-tests.html View 1 chunk +0 lines, -64 lines 0 comments Download
D Tools/GardeningServer/ui/ct-results-comparison-tests.html View 1 chunk +0 lines, -76 lines 0 comments Download
D Tools/GardeningServer/ui/ct-results-detail-tests.html View 1 chunk +0 lines, -149 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-panel-tests.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-revision-details-tests.html View 2 chunks +2 lines, -1 line 0 comments Download
M Tools/GardeningServer/ui/ct-test-list-tests.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-tree-status-tests.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/ui/test/ct-builder-grid-tests.html View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html View 1 chunk +20 lines, -45 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-party-time-tests.html View 1 1 chunk +25 lines, -13 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-results-by-builder-tests.html View 1 chunk +46 lines, -36 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-results-comparison-tests.html View 1 1 chunk +59 lines, -46 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-results-detail-tests.html View 1 1 chunk +115 lines, -114 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
michaelpg
This patch might be a little rough around the edges but I'm sending it out ...
6 years, 4 months ago (2014-08-12 01:52:20 UTC) #1
ojan
lgtm https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/scripts/network_simulator.js File Tools/GardeningServer/scripts/network_simulator.js (right): https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/scripts/network_simulator.js#newcode1 Tools/GardeningServer/scripts/network_simulator.js:1: /* This should be an html file so ...
6 years, 4 months ago (2014-08-12 02:01:19 UTC) #2
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-12 02:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/459463003/40001
6 years, 4 months ago (2014-08-12 02:30:25 UTC) #4
michaelpg
The CQ bit was unchecked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-12 03:11:19 UTC) #5
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-12 03:12:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/459463003/60001
6 years, 4 months ago (2014-08-12 03:13:34 UTC) #7
commit-bot: I haz the power
Change committed as 180026
6 years, 4 months ago (2014-08-12 03:14:26 UTC) #8
michaelpg
6 years, 4 months ago (2014-08-14 00:46:02 UTC) #9
Message was sent while issue was closed. 
(forgot to publish drafts)

https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/network_simulator.js (right):

https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/network_simulator.js:1: /*
On 2014/08/12 02:01:18, ojan-only-code-yellow-reviews wrote:
> This should be an html file so we can pull it in with html imports.

Done.

https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/test/r...
File Tools/GardeningServer/test/run-unit-tests.html (right):

https://codereview.chromium.org/459463003/diff/1/Tools/GardeningServer/test/r...
Tools/GardeningServer/test/run-unit-tests.html:12: <script
src="../scripts/network_simulator.js"></script>
On 2014/08/12 02:01:18, ojan-only-code-yellow-reviews wrote:
> Even better would be if each -tests.html file that used network_simulator
> imported it. I'm fine leaving that as a FIXME though. It's not that important.

Done (for mocha tests).

Powered by Google App Engine
This is Rietveld 408576698