content/browser/devtools/embedded_worker_devtools_agent_host.h - Issue 459403002: DevTools: Added service workers to remote debugging targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/embedded_worker_devtools_agent_host.h

Issue 459403002: DevTools: Added service workers to remote debugging targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made RVDTAH::GetURL consistent with tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/embedded_worker_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/embedded_worker_devtools_agent_host.h

diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.h b/content/browser/devtools/embedded_worker_devtools_agent_host.h

index 03b8638626aab5801bcafd019f8b27e9e8d8cfff..8c032c7c3758d3dd0c4c14073b2bc51ae67ca1ba 100644

--- a/content/browser/devtools/embedded_worker_devtools_agent_host.h

+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.h

@@ -29,6 +29,11 @@ class EmbeddedWorkerDevToolsAgentHost : public IPCDevToolsAgentHost,

// DevToolsAgentHost override.

virtual bool IsWorker() const OVERRIDE;

+ virtual Type GetType() OVERRIDE;

+ virtual std::string GetTitle() OVERRIDE;

+ virtual GURL GetURL() OVERRIDE;

+ virtual bool Activate() OVERRIDE;

+ virtual bool Close() OVERRIDE;

// IPCDevToolsAgentHost implementation.

virtual void SendMessageToAgent(IPC::Message* message) OVERRIDE;

@@ -45,9 +50,7 @@ class EmbeddedWorkerDevToolsAgentHost : public IPCDevToolsAgentHost,

void WorkerDestroyed();

bool Matches(const SharedWorkerInstance& other);

bool Matches(const ServiceWorkerIdentifier& other);

- virtual GURL GetURL();

- virtual bool Close();

+ bool IsTerminated();

private:

friend class EmbeddedWorkerDevToolsManagerTest;