Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: android_webview/native/aw_dev_tools_server.cc

Issue 459403002: DevTools: Added service workers to remote debugging targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remote debugger is now properly notified of service worker being closed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_dev_tools_server.h" 5 #include "android_webview/native/aw_dev_tools_server.h"
6 6
7 #include "android_webview/native/aw_contents.h" 7 #include "android_webview/native/aw_contents.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 19 matching lines...) Expand all
30 const char kFrontEndURL[] = 30 const char kFrontEndURL[] =
31 "http://chrome-devtools-frontend.appspot.com/serve_rev/%s/devtools.html"; 31 "http://chrome-devtools-frontend.appspot.com/serve_rev/%s/devtools.html";
32 const char kSocketNameFormat[] = "webview_devtools_remote_%d"; 32 const char kSocketNameFormat[] = "webview_devtools_remote_%d";
33 33
34 const char kTargetTypePage[] = "page"; 34 const char kTargetTypePage[] = "page";
35 35
36 std::string GetViewDescription(WebContents* web_contents); 36 std::string GetViewDescription(WebContents* web_contents);
37 37
38 class Target : public content::DevToolsTarget { 38 class Target : public content::DevToolsTarget {
39 public: 39 public:
40 explicit Target(WebContents* web_contents); 40 explicit Target(scoped_refptr<DevToolsAgentHost> agent_host);
41 41
42 virtual std::string GetId() const OVERRIDE { return id_; } 42 virtual std::string GetId() const OVERRIDE { return agent_host_->GetId(); }
43 virtual std::string GetParentId() const OVERRIDE { return std::string(); } 43 virtual std::string GetParentId() const OVERRIDE { return std::string(); }
44 virtual std::string GetType() const OVERRIDE { return kTargetTypePage; } 44 virtual std::string GetType() const OVERRIDE {
45 virtual std::string GetTitle() const OVERRIDE { return title_; } 45 std::string result = agent_host_->GetType();
46 if (result == DevToolsAgentHost::kTypeWebContents)
47 result = kTargetTypePage;
48 return result;
49 }
50 virtual std::string GetTitle() const OVERRIDE {
51 return agent_host_->GetTitle();
52 }
46 virtual std::string GetDescription() const OVERRIDE { return description_; } 53 virtual std::string GetDescription() const OVERRIDE { return description_; }
47 virtual GURL GetURL() const OVERRIDE { return url_; } 54 virtual GURL GetURL() const OVERRIDE { return agent_host_->GetURL(); }
48 virtual GURL GetFaviconURL() const OVERRIDE { return GURL(); } 55 virtual GURL GetFaviconURL() const OVERRIDE { return GURL(); }
49 virtual base::TimeTicks GetLastActivityTime() const OVERRIDE { 56 virtual base::TimeTicks GetLastActivityTime() const OVERRIDE {
50 return last_activity_time_; 57 return last_activity_time_;
51 } 58 }
52 virtual bool IsAttached() const OVERRIDE { 59 virtual bool IsAttached() const OVERRIDE {
53 return agent_host_->IsAttached(); 60 return agent_host_->IsAttached();
54 } 61 }
55 virtual scoped_refptr<DevToolsAgentHost> GetAgentHost() const OVERRIDE { 62 virtual scoped_refptr<DevToolsAgentHost> GetAgentHost() const OVERRIDE {
56 return agent_host_; 63 return agent_host_;
57 } 64 }
58 virtual bool Activate() const OVERRIDE { return false; } 65 virtual bool Activate() const OVERRIDE { return agent_host_->Activate(); }
59 virtual bool Close() const OVERRIDE { return false; } 66 virtual bool Close() const OVERRIDE { return agent_host_->Close(); }
60 67
61 private: 68 private:
62 scoped_refptr<DevToolsAgentHost> agent_host_; 69 scoped_refptr<DevToolsAgentHost> agent_host_;
63 std::string id_;
64 std::string title_;
65 std::string description_; 70 std::string description_;
66 GURL url_;
67 base::TimeTicks last_activity_time_; 71 base::TimeTicks last_activity_time_;
68 }; 72 };
69 73
70 Target::Target(WebContents* web_contents) { 74 Target::Target(scoped_refptr<DevToolsAgentHost> agent_host)
71 agent_host_ = 75 : agent_host_(agent_host) {
72 DevToolsAgentHost::GetOrCreateFor(web_contents); 76 if (WebContents* web_contents = agent_host->GetWebContents()) {
73 id_ = agent_host_->GetId(); 77 description_ = GetViewDescription(web_contents);
74 description_ = GetViewDescription(web_contents); 78 last_activity_time_ = web_contents->GetLastActiveTime();
75 title_ = base::UTF16ToUTF8(web_contents->GetTitle()); 79 }
76 url_ = web_contents->GetURL();
77 last_activity_time_ = web_contents->GetLastActiveTime();
78 } 80 }
79 81
80 // Delegate implementation for the devtools http handler for WebView. A new 82 // Delegate implementation for the devtools http handler for WebView. A new
81 // instance of this gets created each time web debugging is enabled. 83 // instance of this gets created each time web debugging is enabled.
82 class AwDevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate { 84 class AwDevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate {
83 public: 85 public:
84 AwDevToolsServerDelegate() {} 86 AwDevToolsServerDelegate() {}
85 virtual ~AwDevToolsServerDelegate() {} 87 virtual ~AwDevToolsServerDelegate() {}
86 88
87 // DevToolsHttpProtocolHandler::Delegate overrides. 89 // DevToolsHttpProtocolHandler::Delegate overrides.
(...skipping 11 matching lines...) Expand all
99 return ""; 101 return "";
100 } 102 }
101 103
102 virtual scoped_ptr<content::DevToolsTarget> CreateNewTarget( 104 virtual scoped_ptr<content::DevToolsTarget> CreateNewTarget(
103 const GURL&) OVERRIDE { 105 const GURL&) OVERRIDE {
104 return scoped_ptr<content::DevToolsTarget>(); 106 return scoped_ptr<content::DevToolsTarget>();
105 } 107 }
106 108
107 virtual void EnumerateTargets(TargetCallback callback) OVERRIDE { 109 virtual void EnumerateTargets(TargetCallback callback) OVERRIDE {
108 TargetList targets; 110 TargetList targets;
109 std::vector<WebContents*> wc_list = 111 DevToolsAgentHost::List agents = DevToolsAgentHost::GetOrCreateAll();
110 DevToolsAgentHost::GetInspectableWebContents(); 112 for (DevToolsAgentHost::List::iterator it = agents.begin();
111 for (std::vector<WebContents*>::iterator it = wc_list.begin(); 113 it != agents.end(); ++it) {
112 it != wc_list.end(); ++it) {
113 targets.push_back(new Target(*it)); 114 targets.push_back(new Target(*it));
114 } 115 }
115 callback.Run(targets); 116 callback.Run(targets);
116 } 117 }
117 118
118 virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering( 119 virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
119 net::StreamListenSocket::Delegate* delegate, 120 net::StreamListenSocket::Delegate* delegate,
120 std::string* name) OVERRIDE { 121 std::string* name) OVERRIDE {
121 return scoped_ptr<net::StreamListenSocket>(); 122 return scoped_ptr<net::StreamListenSocket>();
122 } 123 }
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 AwDevToolsServer* devtools_server = 218 AwDevToolsServer* devtools_server =
218 reinterpret_cast<AwDevToolsServer*>(server); 219 reinterpret_cast<AwDevToolsServer*>(server);
219 if (enabled) { 220 if (enabled) {
220 devtools_server->Start(); 221 devtools_server->Start();
221 } else { 222 } else {
222 devtools_server->Stop(); 223 devtools_server->Stop();
223 } 224 }
224 } 225 }
225 226
226 } // namespace android_webview 227 } // namespace android_webview
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_server.cc » ('j') | chrome/browser/devtools/devtools_target_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698