DevTools: Added service workers to remote debugging targets

content/browser/devtools/embedded_worker_devtools_agent_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/embedded_worker_devtools_agent_host.h"
 
+#include "base/strings/utf_string_conversions.h"
 #include "content/browser/devtools/devtools_manager_impl.h"
 #include "content/browser/devtools/devtools_protocol.h"
 #include "content/browser/devtools/devtools_protocol_constants.h"
+#include "content/browser/shared_worker/shared_worker_service_impl.h"
 #include "content/common/devtools_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 
 namespace content {
 
 EmbeddedWorkerDevToolsAgentHost::EmbeddedWorkerDevToolsAgentHost(
     WorkerId worker_id,
     const SharedWorkerInstance& shared_worker)
     : shared_worker_(new SharedWorkerInstance(shared_worker)),
@@ skipping 11 matching lines @@
       worker_id_(worker_id) {
   if (debug_service_worker_on_start)
     state_ = WORKER_PAUSED_FOR_DEBUG_ON_START;
   WorkerCreated();
 }
 
 bool EmbeddedWorkerDevToolsAgentHost::IsWorker() const {
   return true;
 }
 
+std::string EmbeddedWorkerDevToolsAgentHost::GetType() {
+  return shared_worker_ ? kTypeWorker : kTypeServiceWorker;
+}
+
+std::string EmbeddedWorkerDevToolsAgentHost::GetTitle() {
+  return shared_worker_ ? base::UTF16ToUTF8(shared_worker_->name()) : "";
+}
+
+GURL EmbeddedWorkerDevToolsAgentHost::GetURL() {
+  return shared_worker_ ? shared_worker_->url() : GURL();

[dgozman, 2014/08/13 15:57:02]

Can we get URL for shared worker?

[vkuzkokov, 2014/08/14 07:48:17]

Service worker, you mean? It requires changes in EmbeddedWorkerInstance which
belong in another CL.

[dgozman, 2014/08/14 08:15:33]

Can we make those changes beforehand? Otherwise you will get disfunctional Close
button as well as no way to differentiate between service workers. I think we
should not expose not yet ready service workers then.

+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Activate() {
+  return false;
+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Close() {
+  if (shared_worker_) {
+    return SharedWorkerServiceImpl::GetInstance()->TerminateWorker(
+        worker_id_.first, worker_id_.second);
+  }
+  return false;

[dgozman, 2014/08/13 15:57:02]

Why can't we close shared worker?

[vkuzkokov, 2014/08/14 07:48:17]

Ditto.

+}
+
 void EmbeddedWorkerDevToolsAgentHost::SendMessageToAgent(
     IPC::Message* message_raw) {
   scoped_ptr<IPC::Message> message(message_raw);
   if (state_ != WORKER_INSPECTED)
     return;
   if (RenderProcessHost* host = RenderProcessHost::FromID(worker_id_.first)) {
     message->set_routing_id(worker_id_.second);
     host->Send(message.release());
   }
 }
@@ skipping 99 matching lines @@
   DevToolsManagerImpl::GetInstance()->DispatchOnInspectorFrontend(
       this, message);
 }
 
 void EmbeddedWorkerDevToolsAgentHost::OnSaveAgentRuntimeState(
     const std::string& state) {
   saved_agent_state_ = state;
 }
 
 }  // namespace content