Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 459313002: Oilpan: RenderMenuList should call PopupMenu::disconnectClient in destroy(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderMenuList.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderMenuList.cpp
diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp
index 08e8db8846753b328a0c401628cc8219a152edf5..1af6a78f40742714009caebd2035596e62b4cecd 100644
--- a/Source/core/rendering/RenderMenuList.cpp
+++ b/Source/core/rendering/RenderMenuList.cpp
@@ -65,9 +65,15 @@ RenderMenuList::RenderMenuList(Element* element)
RenderMenuList::~RenderMenuList()
{
+ ASSERT(!m_popup);
+}
+
+void RenderMenuList::destroy()
+{
if (m_popup)
m_popup->disconnectClient();
m_popup = nullptr;
+ RenderFlexibleBox::destroy();
}
void RenderMenuList::trace(Visitor* visitor)
« no previous file with comments | « Source/core/rendering/RenderMenuList.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698