Fix 500 in test results server when querying testlistjson

Tools/TestResultServer/handlers/testfilehandler_test.py

 #!/usr/bin/env python
 
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import json
 import imp
 import logging
@@ skipping 99 matching lines @@
             {'results': [[1, 'Q']], 'times': [[1, 1]]})
 
         # test testlistjson=1
         params[testfilehandler.PARAM_TEST_LIST_JSON] = '1'
 
         response = self.testapp.get('/testfile', params=params)
         self.assertEqual(response.status_int, 200)
         response_json = json.loads(response.normal_body)
         self.assertEqual(response_json[builder]['tests']['Test1.testproc1'], {})
 
+    def test_get_nonexistant_results(self):
+        master = master_config.getMaster('chromium.chromiumos')
+        builder = 'test-builder'
+        test_type = 'test-type'
+
+        params = collections.OrderedDict([
+            (testfilehandler.PARAM_BUILDER, builder),
+            (testfilehandler.PARAM_MASTER, master['url_name']),
+            (testfilehandler.PARAM_TEST_TYPE, test_type),
+            (testfilehandler.PARAM_NAME, 'results.json')
+        ])
+
+        try:
+            response = self.testapp.get('/testfile', params=params)
+        except webtest.app.AppError as e:
+            # FIXME: Is there a better way to check for a 404?
+            self.assertIn('404', e.message)
+
+        params[testfilehandler.PARAM_TEST_LIST_JSON] = '1'
+
+        try:
+            response = self.testapp.get('/testfile', params=params)
+        except webtest.app.AppError as e:
+            # FIXME: Is there a better way to check for a 404?
+            self.assertIn('404', e.message)
+
     def test_deprecated_master_name(self):
         """Verify that a file uploaded with a deprecated master name
         can be downloaded by the corresponding new-style master name.
         """
         master = master_config.getMaster('chromium.chromiumos')
         builder = 'test-builder'
         test_type = 'test-type'
         test_data = {
             'tests': {
                 'Test1.testproc1': {
@@ skipping 47 matching lines @@
             (testfilehandler.PARAM_NAME, 'full_results.json')
         ])
         response = self.testapp.get('/testfile', params=params)
         self.assertEqual(response.status_int, 200)
         response_json = json.loads(response.normal_body)
         self.assertEqual(response_json['chromium_revision'], '67890')
 
 if __name__ == '__main__':
     logging.basicConfig(level=logging.ERROR)
     unittest.main()