Issue 459243004: Fix 500 in test results server when querying testlistjson

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459243004: Fix 500 in test results server when querying testlistjson (Closed)

Created:
6 years, 4 months ago by ojan

Modified:
6 years, 4 months ago

Reviewers:
szager1

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Fix 500 in test results server when querying testlistjson If the file doesn't exist in the repo, we should return a 400 instead of throwing an error and returning a 500. TBR since this is causing 500s on the live server. TBR=szager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180016

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	Tools/TestResultServer/handlers/testfilehandler.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Tools/TestResultServer/handlers/testfilehandler_test.py	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

ojan

6 years, 4 months ago (2014-08-12 00:55:39 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as 180016 (presubmit successful).