Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_database_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/mock_browsing_data_database_helper.cc
diff --git a/chrome/browser/browsing_data/mock_browsing_data_database_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_database_helper.cc
index 3db7ca9fe3adcfee15931a10577b1c38b16fe65f..dc82758f1303448e7628ca40acc8e7db2cefe02e 100644
--- a/chrome/browser/browsing_data/mock_browsing_data_database_helper.cc
+++ b/chrome/browser/browsing_data/mock_browsing_data_database_helper.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/browsing_data/mock_browsing_data_database_helper.h"
#include "base/callback.h"
+#include "testing/gtest/include/gtest/gtest.h"
MockBrowsingDataDatabaseHelper::MockBrowsingDataDatabaseHelper(
Profile* profile)
@@ -16,14 +17,17 @@ MockBrowsingDataDatabaseHelper::~MockBrowsingDataDatabaseHelper() {
void MockBrowsingDataDatabaseHelper::StartFetching(
const base::Callback<void(const std::list<DatabaseInfo>&)>& callback) {
+ ASSERT_FALSE(callback.is_null());
+ ASSERT_TRUE(callback_.is_null());
callback_ = callback;
}
void MockBrowsingDataDatabaseHelper::DeleteDatabase(
const std::string& origin,
const std::string& name) {
+ ASSERT_FALSE(callback_.is_null());
std::string key = origin + ":" + name;
- CHECK(databases_.find(key) != databases_.end());
+ ASSERT_TRUE(databases_.find(key) != databases_.end());
last_deleted_origin_ = origin;
last_deleted_db_ = name;
databases_[key] = false;
@@ -43,7 +47,6 @@ void MockBrowsingDataDatabaseHelper::AddDatabaseSamples() {
}
void MockBrowsingDataDatabaseHelper::Notify() {
- CHECK_EQ(false, callback_.is_null());
callback_.Run(response_);
}

Powered by Google App Engine
This is Rietveld 408576698