Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 459223002: Sheriff-O-Matic: Fix karma for testing (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
Reviewers:
esprehn, ojan
CC:
abarth-chromium, blink-reviews, Dirk Pranke, dsinclair, dstockwell, leviw_travelin_and_unemployed, szager1
Project:
blink
Visibility:
Public.

Description

Sheriff-O-Matic: Fix karma for testing Including polymer.html in karma.conf.js makes platform.js throw "Possible attempt to load Polymer twice" when a polymer component is imported. I think this is because polymer.html is loaded twice: once by karma and again on the first time that the browser encounters a <link href="polymer.html">. I believe this might happen because of the way karma includes files by appending some kind of hash to them. If polymer.html is parsed twice, then the <script src="polymer.js"> also runs twice. This CL adds karma-loader.html which imports polymer.html (so it should avoid importing it a second time) and adds a listener for polymer-ready, which I didn't think was necessary but seems to resolve some flakiness in karma. BUG=400387 R=ojan@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180017

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M Tools/GardeningServer/karma.conf.js View 1 chunk +11 lines, -11 lines 0 comments Download
A + Tools/GardeningServer/test/karma_loader.html View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaelpg
6 years, 4 months ago (2014-08-11 22:37:38 UTC) #1
ojan
lgtm
6 years, 4 months ago (2014-08-11 23:33:19 UTC) #2
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-11 23:33:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/459223002/140001
6 years, 4 months ago (2014-08-11 23:34:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 00:31:22 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 01:09:31 UTC) #6
Message was sent while issue was closed.
Change committed as 180017

Powered by Google App Engine
This is Rietveld 408576698