Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 459203004: Have DocumentOrderedMap API deal with AtomicString type instead of StringImpl* (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Have DocumentOrderedMap API deal with AtomicString type instead of StringImpl* Have DocumentOrderedMap API deal with AtomicString type instead of StringImpl* as it would be unsafe to use if the StringImpls were not atomized. This basically moves the AtomicString::impl() calls from the DocumentOrderedMap API call sites to the DocumentOrderedMap implementation. This simplifies the call sites a bit and makes the DocumentOrderedMap code look safer. R=morrita@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180022

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -52 lines) Patch
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 3 chunks +16 lines, -14 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 6 chunks +21 lines, -21 lines 0 comments Download
M Source/core/dom/TreeScope.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
6 years, 4 months ago (2014-08-12 00:32:38 UTC) #1
Hajime Morrita
LGTM. "Look safer" precisely states the situation :-/ (Not blaming you. Just mumbling.)
6 years, 4 months ago (2014-08-12 00:47:30 UTC) #2
Hajime Morrita
The bot redness seems real btw.
6 years, 4 months ago (2014-08-12 00:48:07 UTC) #3
haraken
LGTM
6 years, 4 months ago (2014-08-12 00:51:12 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-12 00:54:53 UTC) #5
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-12 00:56:46 UTC) #6
Inactive
On 2014/08/12 00:48:07, morrita wrote: > The bot redness seems real btw. Right, I have ...
6 years, 4 months ago (2014-08-12 00:57:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/459203004/1
6 years, 4 months ago (2014-08-12 00:58:53 UTC) #8
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-12 01:16:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/459203004/40001
6 years, 4 months ago (2014-08-12 01:17:36 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 02:03:25 UTC) #11
Message was sent while issue was closed.
Change committed as 180022

Powered by Google App Engine
This is Rietveld 408576698