Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 459153002: Revert r174133, r178901 and r178981 to fix Mac (Closed)

Created:
6 years, 4 months ago by eseidel
Modified:
6 years, 4 months ago
Reviewers:
behdad_google, eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, behdad, ch.dumez
Project:
blink
Visibility:
Public.

Description

Revert r174133, r178901 and r178981 to fix Mac There was a regression bug filed (bug 377445) shortly after the original commit, however the author chose not to revert, but rather instead attempt a fix. The later of those fixes was marked not lgtm' by another reviewer. I'm rolling out the whole mess to unblock shipping M37. R=eae BUG=377445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180004

Patch Set 1 #

Patch Set 2 : Use NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -31 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +9 lines, -0 lines 0 comments Download
D LayoutTests/fast/text/bidi-ignorable-unicode.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/linux/fast/text/bidi-ignorable-unicode-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/platform/fonts/Character.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eseidel
6 years, 4 months ago (2014-08-11 19:50:26 UTC) #1
eae
LGTM
6 years, 4 months ago (2014-08-11 19:51:09 UTC) #2
behdad_google
lgtm
6 years, 4 months ago (2014-08-11 19:55:44 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-11 20:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/459153002/1
6 years, 4 months ago (2014-08-11 20:07:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 21:20:31 UTC) #6
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-11 21:41:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/459153002/20001
6 years, 4 months ago (2014-08-11 21:41:23 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 22:37:07 UTC) #9
commit-bot: I haz the power
Change committed as 180004
6 years, 4 months ago (2014-08-11 23:10:07 UTC) #10
Inactive
Just for the record, Joshi did not really attempt to fix the issue. He merely ...
6 years, 4 months ago (2014-08-12 13:14:57 UTC) #11
eseidel
6 years, 4 months ago (2014-08-12 17:45:19 UTC) #12
Message was sent while issue was closed.
Thank you for clarifying Chris.

Powered by Google App Engine
This is Rietveld 408576698