Remove status icon if there are no more notifications.

Remove status icon if there are no more notifications.

This will match the behavior on ChromeOS and ensure that users without
notifications will not be annoyed by the Chrome notifications center
icon in the status tray.

BUG=401215
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289128

[dewittj, 2014-08-11 18:45:55]

PTAL

[Jun Mukai, 2014-08-11 19:13:40]

lgtm with a nit

https://codereview.chromium.org/459123002/diff/1/chrome/browser/ui/views/mess...
File chrome/browser/ui/views/message_center/web_notification_tray.cc (right):

https://codereview.chromium.org/459123002/diff/1/chrome/browser/ui/views/mess...
chrome/browser/ui/views/message_center/web_notification_tray.cc:281: if
(visible_notifications == 0) {
Why not simply
if (message_center()->GetVisibleNotifications().empty()) {
   ...
}

?

[dewittj, 2014-08-11 19:51:24]

https://codereview.chromium.org/459123002/diff/1/chrome/browser/ui/views/mess...
File chrome/browser/ui/views/message_center/web_notification_tray.cc (right):

https://codereview.chromium.org/459123002/diff/1/chrome/browser/ui/views/mess...
chrome/browser/ui/views/message_center/web_notification_tray.cc:281: if
(visible_notifications == 0) {
On 2014/08/11 19:13:40, Jun Mukai wrote:
> Why not simply
> if (message_center()->GetVisibleNotifications().empty()) {
>    ...
> }
> 
> ?

Done.

[dewittj, 2014-08-11 19:51:29]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-08-11 19:53:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/459123002/20001

[commit-bot: I haz the power, 2014-08-11 23:54:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 00:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:18:13]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[dewittj, 2014-08-12 00:18:40]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:29:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/459123002/20001

[commit-bot: I haz the power, 2014-08-12 04:49:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 06:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 06:31:28]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[dewittj, 2014-08-12 21:01:29]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-08-12 21:08:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/459123002/40001

[commit-bot: I haz the power, 2014-08-13 00:08:08]

Change committed as 289128