Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 459103005: Introduce new PasswordForm attributes for Credential Management API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc
index 7697be7e01a8172e5c3ff271938ef09083ad3610..146206dee85e85bb86f94efc202823ed4c4c3132 100644
--- a/components/password_manager/core/browser/login_database_unittest.cc
+++ b/components/password_manager/core/browser/login_database_unittest.cc
@@ -135,6 +135,10 @@ TEST_F(LoginDatabaseTest, Logins) {
form.times_used = 1;
form.form_data.name = ASCIIToUTF16("form_name");
form.date_synced = base::Time::Now();
+ form.display_name = ASCIIToUTF16("Mr. Smith");
+ form.avatar_url = GURL("https://accounts.google.com/Avatar");
+ form.federation_url = GURL("https://accounts.google.com/federation");
+ form.is_zero_click = true;
// Add it and make sure it is there and that all the fields were retrieved
// correctly.
@@ -589,6 +593,11 @@ static bool AddTimestampedLogin(LoginDatabase* db,
form.password_element = ASCIIToUTF16(unique_string);
form.submit_element = ASCIIToUTF16("signIn");
form.signon_realm = url;
+ form.display_name = ASCIIToUTF16(unique_string);
+ form.avatar_url = GURL("https://accounts.google.com/Avatar");
+ form.federation_url = GURL("https://accounts.google.com/federation");
+ form.is_zero_click = true;
+
if (date_is_creation)
form.date_created = time;
else
@@ -709,6 +718,10 @@ TEST_F(LoginDatabaseTest, BlacklistedLogins) {
form.blacklisted_by_user = true;
form.scheme = PasswordForm::SCHEME_HTML;
form.date_synced = base::Time::Now();
+ form.display_name = ASCIIToUTF16("Mr. Smith");
+ form.avatar_url = GURL("https://accounts.google.com/Avatar");
+ form.federation_url = GURL("https://accounts.google.com/federation");
+ form.is_zero_click = true;
EXPECT_EQ(AddChangeForForm(form), db_.AddLogin(form));
// Get all non-blacklisted logins (should be none).
@@ -926,6 +939,10 @@ TEST_F(LoginDatabaseTest, UpdateLogin) {
form.blacklisted_by_user = true;
form.scheme = PasswordForm::SCHEME_BASIC;
form.type = PasswordForm::TYPE_GENERATED;
+ form.display_name = ASCIIToUTF16("Mr. Smith");
+ form.avatar_url = GURL("https://accounts.google.com/Avatar");
+ form.federation_url = GURL("https://accounts.google.com/federation");
+ form.is_zero_click = true;
EXPECT_EQ(UpdateChangeForForm(form), db_.UpdateLogin(form));
ScopedVector<autofill::PasswordForm> result;

Powered by Google App Engine
This is Rietveld 408576698