Introduce new PasswordForm attributes for Credential Management API.

components/password_manager/core/browser/login_database_unittest.cc

Index: components/password_manager/core/browser/login_database_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc
index 7697be7e01a8172e5c3ff271938ef09083ad3610..7642d55ef878a6b8cf965b6ebeba3e6887cdfdce 100644
--- a/components/password_manager/core/browser/login_database_unittest.cc
+++ b/components/password_manager/core/browser/login_database_unittest.cc
@@ -135,6 +135,10 @@ TEST_F(LoginDatabaseTest, Logins) {
   form.times_used = 1;
   form.form_data.name = ASCIIToUTF16("form_name");
   form.date_synced = base::Time::Now();
+  form.display_name = ASCIIToUTF16("Mr. Smith");
+  form.avatar_url = GURL("http://accounts.google.com/Avatar");

[Mike West, 2014/08/18 18:52:12]

Nit: HTTPS, please. We're not going to accept insecure URLs for either of these
values.

[vasilii, 2014/08/20 11:45:35]

Done.

+  form.federation_url = GURL("http://accounts.google.com/federation");
+  form.is_zero_click = true;
 
   // Add it and make sure it is there and that all the fields were retrieved
   // correctly.
@@ -589,6 +593,11 @@ static bool AddTimestampedLogin(LoginDatabase* db,
   form.password_element = ASCIIToUTF16(unique_string);
   form.submit_element = ASCIIToUTF16("signIn");
   form.signon_realm = url;
+  form.display_name = ASCIIToUTF16(unique_string);
+  form.avatar_url = GURL("http://accounts.google.com/Avatar");
+  form.federation_url = GURL("http://accounts.google.com/federation");

[Mike West, 2014/08/18 18:52:12]

Nit: Here too. :)

[vasilii, 2014/08/20 11:45:34]

Done.

+  form.is_zero_click = true;
+
   if (date_is_creation)
     form.date_created = time;
   else
@@ -709,6 +718,10 @@ TEST_F(LoginDatabaseTest, BlacklistedLogins) {
   form.blacklisted_by_user = true;
   form.scheme = PasswordForm::SCHEME_HTML;
   form.date_synced = base::Time::Now();
+  form.display_name = ASCIIToUTF16("Mr. Smith");
+  form.avatar_url = GURL("http://accounts.google.com/Avatar");
+  form.federation_url = GURL("http://accounts.google.com/federation");
+  form.is_zero_click = true;
   EXPECT_EQ(AddChangeForForm(form), db_.AddLogin(form));
 
   // Get all non-blacklisted logins (should be none).
@@ -926,6 +939,10 @@ TEST_F(LoginDatabaseTest, UpdateLogin) {
   form.blacklisted_by_user = true;
   form.scheme = PasswordForm::SCHEME_BASIC;
   form.type = PasswordForm::TYPE_GENERATED;
+  form.display_name = ASCIIToUTF16("Mr. Smith");
+  form.avatar_url = GURL("http://accounts.google.com/Avatar");
+  form.federation_url = GURL("http://accounts.google.com/federation");

[Mike West, 2014/08/18 18:52:12]

Nit: And here.

[vasilii, 2014/08/20 11:45:35]

Done.

+  form.is_zero_click = true;
   EXPECT_EQ(UpdateChangeForForm(form), db_.UpdateLogin(form));
 
   ScopedVector<autofill::PasswordForm> result;