Introduce new PasswordForm attributes for Credential Management API.

chrome/browser/password_manager/password_store_mac_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_mac.h"
 
 #include "base/basictypes.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_vector.h"
 #include "base/path_service.h"
@@ skipping 185 matching lines @@
   if (form_data.action)
     form->action = GURL(form_data.action);
   if (form_data.submit_element)
     form->submit_element = WideToUTF16(form_data.submit_element);
   if (form_data.username_element)
     form->username_element = WideToUTF16(form_data.username_element);
   if (form_data.password_element)
     form->password_element = WideToUTF16(form_data.password_element);
   if (form_data.username_value) {
     form->username_value = WideToUTF16(form_data.username_value);
+    form->display_name = form->username_value;
+    form->is_zero_click = true;
     if (form_data.password_value)
       form->password_value = WideToUTF16(form_data.password_value);
   } else {
     form->blacklisted_by_user = true;
   }
+  form->avatar_url = GURL("http://accounts.google.com/Avatar");
+  form->federation_url = GURL("http://accounts.google.com/login");

[Mike West, 2014/08/18 18:52:11]

Nit: HTTPS throughout. :)

[vasilii, 2014/08/20 11:45:34]

Done.

   return form;
 }
 
 // Macro to simplify calling CheckFormsAgainstExpectations with a useful label.
 #define CHECK_FORMS(forms, expectations, i) \
     CheckFormsAgainstExpectations(forms, expectations, #forms, i)
 
 // Ensures that the data in |forms| match |expectations|, causing test failures
 // for any discrepencies.
 // TODO(stuartmorgan): This is current order-dependent; ideally it shouldn't
@@ skipping 22 matching lines @@
     EXPECT_EQ(GURL(expectation->action), form->action) << test_label;
     EXPECT_EQ(WideToUTF16(expectation->submit_element), form->submit_element)
         << test_label;
     EXPECT_EQ(WideToUTF16(expectation->username_element),
               form->username_element) << test_label;
     EXPECT_EQ(WideToUTF16(expectation->password_element),
               form->password_element) << test_label;
     if (expectation->username_value) {
       EXPECT_EQ(WideToUTF16(expectation->username_value),
                 form->username_value) << test_label;
+      EXPECT_EQ(WideToUTF16(expectation->username_value),
+                form->display_name) << test_label;
+      EXPECT_TRUE(form->is_zero_click) << test_label;
       EXPECT_EQ(WideToUTF16(expectation->password_value),
                 form->password_value) << test_label;
     } else {
       EXPECT_TRUE(form->blacklisted_by_user) << test_label;
     }
     EXPECT_EQ(expectation->preferred, form->preferred)  << test_label;
     EXPECT_EQ(expectation->ssl_valid, form->ssl_valid) << test_label;
     EXPECT_DOUBLE_EQ(expectation->creation_time,
                      form->date_created.ToDoubleT()) << test_label;
     base::Time created = base::Time::FromDoubleT(expectation->creation_time);
     EXPECT_EQ(created + base::TimeDelta::FromDays(1),
               form->date_synced) << test_label;
+    EXPECT_EQ(GURL("http://accounts.google.com/Avatar"), form->avatar_url);
+    EXPECT_EQ(GURL("http://accounts.google.com/login"), form->federation_url);
   }
 }
 
 #pragma mark -
 
 TEST_F(PasswordStoreMacInternalsTest, TestKeychainToFormTranslation) {
   typedef struct {
     const PasswordForm::Scheme scheme;
     const char* signon_realm;
     const char* origin;
@@ skipping 1169 matching lines @@
   ASSERT_EQ(1u, matching_items.size());
   EXPECT_EQ(ASCIIToUTF16("joe_user"), matching_items[0]->username_value);
   matching_items.clear();
 
   // Check the third-party password is still there.
   owned_keychain_adapter.SetFindsOnlyOwnedItems(false);
   matching_items.get() = owned_keychain_adapter.PasswordsFillingForm(
       "http://some.domain.com/insecure.html", PasswordForm::SCHEME_HTML);
   ASSERT_EQ(1u, matching_items.size());
 }