aw: Use async upload by default

aw: Use async upload by default

BUG=399311
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289252

[boliu, 2014-08-11 16:11:05]

This is waiting on https://codereview.chromium.org/455083002/ and
https://codereview.chromium.org/463563002/

[hush (inactive), 2014-08-11 17:12:50]

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
android_webview/lib/main/aw_main_delegate.cc:56:
cl->HasSwitch(switches::kEnableZeroCopy) &&
we have both kEnableZeroCopy and kDisableZeroCopy in content_switches.cc

This seems redundant, and confusing if you pass both options in the command
line.

But it seems both options are used in content/ folder. What's the point?
Can we keep kDisableZeroCopy and remove kEnableZeroCopy?

[boliu, 2014-08-11 17:15:07]

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
android_webview/lib/main/aw_main_delegate.cc:56:
cl->HasSwitch(switches::kEnableZeroCopy) &&
On 2014/08/11 17:12:49, hush wrote:
> we have both kEnableZeroCopy and kDisableZeroCopy in content_switches.cc
> 
> This seems redundant, and confusing if you pass both options in the command
> line.

The rule is always disable trumps enable.

> 
> But it seems both options are used in content/ folder. What's the point?

I don't actually know. I'd guess it probably has something to do with running
experiments and easily flipping the default case.

> Can we keep kDisableZeroCopy and remove kEnableZeroCopy?

Ehh, follow up clean up

[hush (inactive), 2014-08-11 17:38:51]

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/459023002/diff/1/android_webview/lib/main/aw_...
android_webview/lib/main/aw_main_delegate.cc:56:
cl->HasSwitch(switches::kEnableZeroCopy) &&
Seems like content owners added it on purpose in this CL:
https://codereview.chromium.org/236313006
On 2014/08/11 17:15:06, boliu wrote:
> On 2014/08/11 17:12:49, hush wrote:
> > we have both kEnableZeroCopy and kDisableZeroCopy in content_switches.cc
> > 
> > This seems redundant, and confusing if you pass both options in the command
> > line.
> 
> The rule is always disable trumps enable.
> 
> > 
> > But it seems both options are used in content/ folder. What's the point?
> 
> I don't actually know. I'd guess it probably has something to do with running
> experiments and easily flipping the default case.
> 
> > Can we keep kDisableZeroCopy and remove kEnableZeroCopy?
> 
> Ehh, follow up clean up

[hush (inactive), 2014-08-12 21:02:26]

lgtm

[boliu, 2014-08-13 03:10:57]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-08-13 03:16:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/459023002/1

[commit-bot: I haz the power, 2014-08-13 10:15:13]

Change committed as 289252