Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 459008: Mac: the return of the tab-modal-sheets patch. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by viettrungluu
Modified:
1 year, 2 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: the return of the tab-modal-sheets patch. WORK IN PROGRESS. This might not even compile without appropriate stuff (which may even have to be modified). This is essentially Patch Set 8 from <http://codereview.chromium.org/164547>;. Much updating and cherry-picking is needed. BUG=19333 TEST=whatever

Patch Set 1 #

Patch Set 2 : Forward-ported much of Patch Set 20. #

Patch Set 3 : Merge ToT. #

Patch Set 4 : Rebased ToT. #

Patch Set 5 : Merged ToT. Must ... commit ... soon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+679 lines, -86 lines) Patch
M chrome/browser/browser.cc View 1 2 3 4 1 chunk +40 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/constrained_window_mac.h View 1 5 chunks +46 lines, -10 lines 0 comments Download
M chrome/browser/cocoa/constrained_window_mac.mm View 1 2 chunks +45 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/shell_dialogs_mac.mm View 1 2 3 4 11 chunks +324 lines, -22 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 2 3 4 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/download/save_package.cc View 1 2 3 4 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/gtk/dialogs_gtk.cc View 1 2 3 4 1 chunk +20 lines, -8 lines 0 comments Download
M chrome/browser/login_prompt_mac.mm View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/shell_dialogs.h View 4 chunks +21 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/constrained_window.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/constrained_window.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 3 4 5 chunks +37 lines, -16 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 chunks +27 lines, -9 lines 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +20 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 4 2 chunks +3 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be