Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: chrome/browser/login_prompt_mac.mm

Issue 459008: Mac: the return of the tab-modal-sheets patch. (Closed)
Patch Set: Merged ToT. Must ... commit ... soon. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/dialogs_gtk.cc ('k') | chrome/browser/shell_dialogs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/login_prompt_mac.mm
diff --git a/chrome/browser/login_prompt_mac.mm b/chrome/browser/login_prompt_mac.mm
index 7446aa2e4958daf26be49a44ddcbf1729b2b76f0..d34effc37c294a92e4d716bd7e224a7cbe4be7b5 100644
--- a/chrome/browser/login_prompt_mac.mm
+++ b/chrome/browser/login_prompt_mac.mm
@@ -80,6 +80,21 @@ class LoginHandlerMac : public LoginHandler,
std::wstring explanation) {
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+ // TODO(viettrungluu): Is this still necessary with thakis's queuing? Let's
+ // hypothesize "no", but I need to check this....
+#if 0
+ TabContents* requesting_contents = GetTabContentsForLogin();
+ DCHECK(requesting_contents);
+
+ // If something goes wrong (e.g., there's already a tab-modal sheet up),
+ // cancel the authorization.
+ if (!requesting_contents ||
+ !requesting_contents->CanCreateConstrainedDialog()) {
+ CancelAuth();
+ return;
+ }
+#endif
+
// Load nib here instead of in constructor.
sheet_controller_ = [[[LoginHandlerSheet alloc]
initWithLoginHandler:this] autorelease];
« no previous file with comments | « chrome/browser/gtk/dialogs_gtk.cc ('k') | chrome/browser/shell_dialogs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698