Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3277)

Unified Diff: chrome/browser/views/browser_bubble.h

Issue 459005: Make sure we don't dismiss extension popups when the focus... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/browser_bubble.h
===================================================================
--- chrome/browser/views/browser_bubble.h (revision 33297)
+++ chrome/browser/views/browser_bubble.h (working copy)
@@ -29,7 +29,10 @@
virtual void BubbleGotFocus(BrowserBubble* bubble) {}
// Called when the bubble became inactive / lost focus.
- virtual void BubbleLostFocus(BrowserBubble* bubble) {}
+ // |focused_view| is the NativeView getting the focus, it may be NULL if the
+ // popup was closed programatically.
+ virtual void BubbleLostFocus(BrowserBubble* bubble,
+ gfx::NativeView focused_view) {}
};
// Note that the bubble will size itself to the preferred size of |view|.
@@ -81,6 +84,9 @@
// Resize the bubble to fit the view.
void ResizeToView();
+ // Returns the NativeView containing that popup.
+ gfx::NativeView native_view() const { return frame_native_view_; }
+
protected:
// Create the popup widget.
virtual void InitPopup();

Powered by Google App Engine
This is Rietveld 408576698