Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 459003: Don't set referrers on outgoing plugin requests if the load_manually flag is ... (Closed)

Created:
11 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam
Visibility:
Public.

Description

Don't set referrers on outgoing plugin requests if the load_manually flag is set. This emulates the behavior of other browsers and fixes http://code.google.com/p/chromium/issues/detail?id=28800 I added a UI test to validate that the plugin source URL is set on outgoing GetURL requests issued by the plugin. To validate that the document URL is set as the referrer on the initial URL request would take some more work. Will try and add that in a future CL. I also changed the WebPluginImpl::RouteToFrame function to set the referrer on similar lines. Bug=28800 Test=Covered by UI test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33673

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -24 lines) Patch
A chrome/test/data/npapi/plugin_ref_target_page.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/npapi/plugin_ref_target_page.html.mock-http-headers View 2 8 9 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/npapi/plugin_url_request_referrer_test.html View 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 2 3 4 5 6 7 8 1 chunk +15 lines, -0 lines 0 comments Download
M webkit/glue/plugins/test/plugin_client.cc View 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/plugins/test/plugin_geturl_test.h View 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/test/plugin_geturl_test.cc View 2 3 4 5 6 7 6 chunks +33 lines, -6 lines 0 comments Download
M webkit/glue/webplugin_impl.h View 1 2 3 4 5 6 7 6 chunks +15 lines, -3 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 3 4 5 6 7 10 chunks +30 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
11 years ago (2009-12-01 23:37:14 UTC) #1
jam
lgtm can we write a test for this? perhaps with the npapi_test_plugin in an iframe ...
11 years ago (2009-12-02 18:11:47 UTC) #2
ananta
On 2009/12/02 18:11:47, John Abd-El-Malek wrote: > lgtm > > can we write a test ...
11 years ago (2009-12-02 20:14:06 UTC) #3
jam
11 years ago (2009-12-03 00:57:02 UTC) #4
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698