DevTools: Omit the "Show documentation" context menu item creation for non-existent JS methods

Source/devtools/front_end/documentation/DocumentationView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 importScript("WikiParser.js");
 importScript("JSArticle.js");
 importScript("CSSArticle.js");
 importScript("DocumentationURLProvider.js");
 
 /**
@@ skipping 32 matching lines @@
     /**
      * @param {!Event} event
      * @param {!WebInspector.ContextMenu} contextMenu
      * @param {!Object} target
      */
     appendApplicableItems: function(event, contextMenu, target)
     {
         if (!(target instanceof WebInspector.CodeMirrorTextEditor))
             return;
         var textEditor = /** @type {!WebInspector.CodeMirrorTextEditor} */ (target);
-        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Show documentation" : "Show Documentation"), this._showDocumentation.bind(this, textEditor));
+        var selectedText = this._getSelection(textEditor);

[apavlov, 2014/08/11 15:04:14]

Blink does not use "get" prefixes. This should be something akin to
"_editorSelection"

+        if (!selectedText)
+            return;
+        var urlProvider = new WebInspector.DocumentationURLProvider();

[apavlov, 2014/08/11 15:04:14]

Can we make it a singleton? It has no state

[semeny, 2014/08/11 15:34:28]

Did not really understand what is wrong and what should I do.

+        var itemPath = urlProvider.itemPath(selectedText);
+        if (!itemPath)
+            return;
+        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Show documentation" : "Show Documentation"), WebInspector.DocumentationView.showSearchTerm.bind(null, selectedText));
     },
 
     /**
      * @param {!WebInspector.CodeMirrorTextEditor} textEditor
+     * @return {?string}
      */
-    _showDocumentation: function(textEditor)
+    _getSelection: function(textEditor)

[lushnikov, 2014/08/11 14:59:47]

no need for the separate function - please, inline

[semeny, 2014/08/11 15:34:28]

Done.

     {
         var selection = textEditor.selection();
-        if (!selection || selection.isEmpty())
-            return;
-        var selectedText = textEditor.copyRange(selection);
-        WebInspector.DocumentationView.showSearchTerm(selectedText);
+        if (!selection || selection.isEmpty() || selection.startLine !== selection.endLine)

[apavlov, 2014/08/11 15:04:14]

Shouldn't this detect the word at cursor if the selection is empty?

[semeny, 2014/08/11 15:34:28]

No, only if property is selected.

+            return null;
+        return textEditor.copyRange(selection);
     }
-}
+}