Source/bindings/core/v8/PageScriptDebugServer.h - Issue 458933002: Fix ScriptPreprocessor leak in inspector test case of LayoutTest.

Side by Side Diff: Source/bindings/core/v8/PageScriptDebugServer.h

Issue 458933002: Fix ScriptPreprocessor leak in inspector test case of LayoutTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/LeakExpectations ('k') | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 Google Inc. All rights reserved.	2 * Copyright (c) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 };	64 };

65 void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);	65 void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);

66	66

67 virtual void compileScript(ScriptState, const String& expression, const Str ing& sourceURL, String scriptId, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace) OVERRIDE;	67 virtual void compileScript(ScriptState, const String& expression, const Str ing& sourceURL, String scriptId, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace) OVERRIDE;

68 virtual void clearCompiledScripts() OVERRIDE;	68 virtual void clearCompiledScripts() OVERRIDE;

69 virtual void runScript(ScriptState, const String& scriptId, ScriptValue re sult, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* colum nNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace) OVERRIDE;	69 virtual void runScript(ScriptState, const String& scriptId, ScriptValue re sult, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* colum nNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace) OVERRIDE;

70 virtual void setPreprocessorSource(const String&) OVERRIDE;	70 virtual void setPreprocessorSource(const String&) OVERRIDE;

71 virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) OVERRID E;	71 virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) OVERRID E;

72 virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSou rceCode&) OVERRIDE;	72 virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSou rceCode&) OVERRIDE;

73 virtual String preprocessEventListener(LocalFrame*, const String& source, co nst String& url, const String& functionName) OVERRIDE;	73 virtual String preprocessEventListener(LocalFrame*, const String& source, co nst String& url, const String& functionName) OVERRIDE;

	74 virtual void clearPreprocessor() OVERRIDE;

74	75

75 virtual void muteWarningsAndDeprecations() OVERRIDE;	76 virtual void muteWarningsAndDeprecations() OVERRIDE;

76 virtual void unmuteWarningsAndDeprecations() OVERRIDE;	77 virtual void unmuteWarningsAndDeprecations() OVERRIDE;

77	78

78 private:	79 private:

79 PageScriptDebugServer();	80 PageScriptDebugServer();

80 virtual ~PageScriptDebugServer();	81 virtual ~PageScriptDebugServer();

81	82

82 virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Conte xt>) OVERRIDE;	83 virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Conte xt>) OVERRIDE;

83 virtual void runMessageLoopOnPause(v8::Handle<v8::Context>) OVERRIDE;	84 virtual void runMessageLoopOnPause(v8::Handle<v8::Context>) OVERRIDE;

84 virtual void quitMessageLoopOnPause() OVERRIDE;	85 virtual void quitMessageLoopOnPause() OVERRIDE;

85	86

86 typedef HashMap<Page, ScriptDebugListener> ListenersMap;	87 typedef HashMap<Page, ScriptDebugListener> ListenersMap;

87 ListenersMap m_listenersMap;	88 ListenersMap m_listenersMap;

88 OwnPtr<ClientMessageLoop> m_clientMessageLoop;	89 OwnPtr<ClientMessageLoop> m_clientMessageLoop;

89 Page* m_pausedPage;	90 Page* m_pausedPage;

90 HashMap<String, String> m_compiledScriptURLs;	91 HashMap<String, String> m_compiledScriptURLs;

91	92

92 OwnPtr<ScriptSourceCode> m_preprocessorSourceCode;	93 OwnPtr<ScriptSourceCode> m_preprocessorSourceCode;

93 OwnPtr<ScriptPreprocessor> m_scriptPreprocessor;	94 OwnPtr<ScriptPreprocessor> m_scriptPreprocessor;

94 bool canPreprocess(LocalFrame*);	95 bool canPreprocess(LocalFrame*);

95 static v8::Isolate* s_mainThreadIsolate;	96 static v8::Isolate* s_mainThreadIsolate;

96 };	97 };

97	98

98 } // namespace blink	99 } // namespace blink

99	100

100	101

101 #endif // PageScriptDebugServer_h	102 #endif // PageScriptDebugServer_h

OLD	NEW