Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 458893003: Fix crash in guest mode (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
Reviewers:
noms (inactive), sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Fix crash in guest mode There is no active profile in guest mode, thus we cannot call avatar_menu->GetItemAt(avatar_menu->GetActiveProfileIndex()) in ProfileChooserView::ShowView unconditionally. Instead the call should be moved to CreateSwitchUserView where it is guaranteed that the current profile is signed in. BUG=402119 R=noms@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289651

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 4 months ago (2014-08-12 19:58:12 UTC) #1
guohui
ping?
6 years, 4 months ago (2014-08-13 20:49:54 UTC) #2
noms (inactive)
lgtm.
6 years, 4 months ago (2014-08-13 20:51:09 UTC) #3
guohui
On 2014/08/13 20:51:09, Monica Dinculescu wrote: > lgtm. Ping sky for owner review? This cl ...
6 years, 4 months ago (2014-08-13 22:32:11 UTC) #4
sky
LGTM
6 years, 4 months ago (2014-08-13 22:50:03 UTC) #5
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-13 23:00:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/458893003/20001
6 years, 4 months ago (2014-08-13 23:04:29 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 05:11:22 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 15:35:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5939)
6 years, 4 months ago (2014-08-14 15:35:21 UTC) #10
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-14 17:00:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/458893003/20001
6 years, 4 months ago (2014-08-14 17:04:28 UTC) #12
guohui
6 years, 4 months ago (2014-08-14 18:48:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as 289651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698