Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 458853002: [ServiceWorker] Add missing method to Cache.idl. (Closed)

Created:
6 years, 4 months ago by gavinp
Modified:
6 years, 4 months ago
Reviewers:
falken, jkarlin
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@2b-cleanup
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add missing method to Cache.idl. The string version of Add() was unfortunately omitted in an earlier CL. R=falken@chromium.org,jkarlin@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179946

Patch Set 1 #

Patch Set 2 : narrow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/modules/serviceworkers/Cache.idl View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
falken: PTAL. jkarlin: FYI. This was an unfortunate omission.
6 years, 4 months ago (2014-08-10 17:24:58 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-11 04:14:01 UTC) #2
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 4 months ago (2014-08-11 13:41:50 UTC) #3
gavinp
thanks for the review. Please always feel free to just go straight to CQ with ...
6 years, 4 months ago (2014-08-11 13:42:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/458853002/20001
6 years, 4 months ago (2014-08-11 13:42:43 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 13:49:09 UTC) #6
Message was sent while issue was closed.
Change committed as 179946

Powered by Google App Engine
This is Rietveld 408576698