Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 458833002: [SVG] Skip layout viewport change calculation when not needed. (Closed)

Created:
6 years, 4 months ago by f(malita)
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

[SVG] Skip layout viewport change calculation when not needed. SVGRenderSupport::layoutChildren() determines whether the size of the nearest viewport has changed upfront, and then uses this information to force a re-layout of relative-length children. But the relative-length flag is always propagated up the ancestor chain (see SVGElement::updateRelativeLengthsInformation), so we can immediately tell whether there are any relative-length descendants. If there aren't, we can skip the viewport change crawl and related logic. R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,ed@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180071

Patch Set 1 #

Patch Set 2 : Drop forced resource inval of non-rel children #

Patch Set 3 : Test + minor cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -33 lines) Patch
A LayoutTests/svg/custom/viewport-resource-inval.svg View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/viewport-resource-inval-expected.svg View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 2 4 chunks +11 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
f(malita)
6 years, 4 months ago (2014-08-10 15:53:16 UTC) #1
kouhei (in TOK)
lgtm
6 years, 4 months ago (2014-08-10 15:56:16 UTC) #2
f(malita)
Actually, I think we can drop the forced resource inval of non-rel children altogether -- ...
6 years, 4 months ago (2014-08-10 16:15:38 UTC) #3
pdr.
On 2014/08/10 16:15:38, Florin Malita wrote: > Actually, I think we can drop the forced ...
6 years, 4 months ago (2014-08-10 20:44:45 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-08-12 13:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/458833002/40001
6 years, 4 months ago (2014-08-12 13:35:21 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 13:41:09 UTC) #7
Message was sent while issue was closed.
Change committed as 180071

Powered by Google App Engine
This is Rietveld 408576698