sync/internal_api/public/attachments/attachment_downloader.h - Issue 458753006: Fix use after free bug by calling GetTokenService in Core's ctor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/internal_api/public/attachments/attachment_downloader.h

Issue 458753006: Fix use after free bug by calling GetTokenService in Core's ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update TSP comment (CANDIDATE). Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« google_apis/gaia/oauth2_token_service_request.cc ('K') | « sync/internal_api/attachments/attachment_uploader_impl_unittest.cc ('k') | sync/internal_api/public/attachments/attachment_downloader_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_	5 #ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_

6 #define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_	6 #define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_

7	7

8 #include "base/callback.h"	8 #include "base/callback.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "google_apis/gaia/oauth2_token_service_request.h"	10 #include "google_apis/gaia/oauth2_token_service_request.h"

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 //	49 //

50 // \|scopes\| is the set of scopes to use for downloads.	50 // \|scopes\| is the set of scopes to use for downloads.

51 //	51 //

52 // \|token_service_provider\| provides an OAuth2 token service.	52 // \|token_service_provider\| provides an OAuth2 token service.

53 static scoped_ptr<AttachmentDownloader> Create(	53 static scoped_ptr<AttachmentDownloader> Create(

54 const GURL& sync_service_url,	54 const GURL& sync_service_url,

55 const scoped_refptr<net::URLRequestContextGetter>&	55 const scoped_refptr<net::URLRequestContextGetter>&

56 url_request_context_getter,	56 url_request_context_getter,

57 const std::string& account_id,	57 const std::string& account_id,

58 const OAuth2TokenService::ScopeSet scopes,	58 const OAuth2TokenService::ScopeSet scopes,

59 scoped_ptr<OAuth2TokenServiceRequest::TokenServiceProvider>	59 const scoped_refptr<OAuth2TokenServiceRequest::TokenServiceProvider>&

60 token_service_provider);	60 token_service_provider);

61 };	61 };

62	62

63 } // namespace syncer	63 } // namespace syncer

64	64

65 #endif // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_	65 #endif // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_DOWNLOADER_H_

OLD	NEW