Issue 458753004: ToNumber(Symbol) should throw TypeError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 458753004: ToNumber(Symbol) should throw TypeError (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)

Modified:
6 years, 3 months ago

Reviewers:
Dmitry Lomov (no reviews), adamk

CC:
v8-dev, caitp (gmail), rossberg

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

ToNumber(Symbol) should throw TypeError https://people.mozilla.org/~jorendorff/es6-draft.html#sec-tonumber Based on patch from caitp <caitpotter88@gmail.com>; https://codereview.chromium.org/454233002/ BUG=v8:3499 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23057

Patch Set 2 : Use IS_SYMBOL instead #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -30 lines)			Patch
M	src/messages.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.js	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/v8natives.js	View	1	1 chunk	+26 lines, -24 lines	0 comments	Download
M	test/mjsunit/es6/symbols.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/private.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/object-toprimitive.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm https://codereview.chromium.org/458753004/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/458753004/diff/1/src/v8natives.js#newcode928 src/v8natives.js:928: if (typeof p !== "symbol") { !IS_SYMBOL(p) is ...

6 years, 4 months ago (2014-08-11 17:58:52 UTC) #2

Dmitry Lomov (no reviews)

6 years, 4 months ago (2014-08-11 19:24:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23057 (presubmit successful).

Expand Messages | Collapse Messages

Issue 458753004: ToNumber(Symbol) should throw TypeError (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use IS_SYMBOL instead #

Messages