Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 458693004: Cast: add UMA for video encode accelerator initialization result. (Closed)

Created:
6 years, 4 months ago by Pawel Osciak
Modified:
6 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: add UMA for video encode accelerator initialization result. Add Cast.Sender.VideoEncodeAcceleratorInitializeSuccess indicating whether we were successful in initializing an external video encode accelerator for cast sender. BUG=397038 TEST=Cast, check histograms Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289029

Patch Set 1 #

Total comments: 1

Patch Set 2 : wording nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M media/cast/sender/external_video_encoder.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Pawel Osciak
PTAL
6 years, 4 months ago (2014-08-09 11:09:56 UTC) #1
hshi1
lgtm
6 years, 4 months ago (2014-08-09 15:36:49 UTC) #2
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-08-11 06:12:30 UTC) #3
Pawel Osciak
The CQ bit was unchecked by posciak@chromium.org
6 years, 4 months ago (2014-08-11 06:12:35 UTC) #4
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-08-12 00:22:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/458693004/1
6 years, 4 months ago (2014-08-12 00:29:58 UTC) #6
Ilya Sherman
histograms lgtm https://codereview.chromium.org/458693004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/458693004/diff/1/tools/metrics/histograms/histograms.xml#newcode2186 tools/metrics/histograms/histograms.xml:2186: + sender has been successful. nit: "has ...
6 years, 4 months ago (2014-08-12 00:35:14 UTC) #7
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-08-12 01:07:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/458693004/20001
6 years, 4 months ago (2014-08-12 01:18:05 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 05:02:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 05:06:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3568)
6 years, 4 months ago (2014-08-12 05:07:00 UTC) #12
Pawel Osciak
On 2014/08/12 05:07:00, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-12 05:50:57 UTC) #13
Alpha Left Google
lgtm
6 years, 4 months ago (2014-08-12 18:13:34 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:25:53 UTC) #15
Message was sent while issue was closed.
Change committed as 289029

Powered by Google App Engine
This is Rietveld 408576698