Source/core/dom/ClassCollection.h - Issue 458663003: getElementsByClassName should include non styled Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ClassCollection.h

Issue 458663003: getElementsByClassName should include non styled Elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use use js-test.js Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/getElementsByClassName/script-tests/non-styled-elements.js ('K') | « LayoutTests/fast/dom/getElementsByClassName/script-tests/non-styled-elements.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ClassCollection.h

diff --git a/Source/core/dom/ClassCollection.h b/Source/core/dom/ClassCollection.h

index 290e70bd0d923ab4efbc12fdf11f8cd618358668..36c693aae34acc4c3cc745f03501da09b3c77472 100644

--- a/Source/core/dom/ClassCollection.h

+++ b/Source/core/dom/ClassCollection.h

@@ -65,10 +65,6 @@ inline bool ClassCollection::elementMatches(const Element& testElement) const

return false;

if (!m_classNames.size())

return false;

- // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.

- // https://bugs.webkit.org/show_bug.cgi?id=94718

- if (!testElement.isStyledElement())

- return false;

return testElement.classNames().containsAll(m_classNames);

}