build/android/pylib/utils/findbugs.py - Issue 458653002: Update lint and findbugs to use jars instead of class files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 458653002: Update lint and findbugs to use jars instead of class files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/utils/findbugs.py

diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py

index fb672680fe1b6cfdef20ba0068977b2f8ab30ef8..4037ebdf7cf4f35c001b5b9c6da240ecc8512889 100644

--- a/build/android/pylib/utils/findbugs.py

+++ b/build/android/pylib/utils/findbugs.py

@@ -70,12 +70,13 @@ def _GetChromeClasses(release_version):

version = 'Debug'

if release_version:

version = 'Release'

- path = os.path.join(constants.DIR_SOURCE_ROOT, 'out', version)

- cmd = 'find %s -name "*.class"' % path

+ path = os.path.join(constants.DIR_SOURCE_ROOT, 'out', version, 'lib.java')

+ cmd = 'find %s -name "*.jar"' % path

out = cmd_helper.GetCmdOutput(shlex.split(cmd))

+ out = [p for p in out.splitlines() if not p.endswith('.dex.jar')]

if not out:

print 'No classes found in %s' % path

- return out

+ return ' '.join(out)

def _Run(exclude, known_bugs, classes_to_analyze, auxiliary_classes,

« no previous file with comments | « build/android/push_libraries.gypi ('k') | build/java.gypi » ('j') | no next file with comments »