Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: build/get_landmines.py

Issue 458653002: Update lint and findbugs to use jars instead of class files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a landmine Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/utils/findbugs.py ('k') | build/java.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 def print_landmines(target): 24 def print_landmines(target):
25 """ 25 """
26 ALL LANDMINES ARE EMITTED FROM HERE. 26 ALL LANDMINES ARE EMITTED FROM HERE.
27 target can be one of {'Release', 'Debug', 'Debug_x64', 'Release_x64'}. 27 target can be one of {'Release', 'Debug', 'Debug_x64', 'Release_x64'}.
28 """ 28 """
29 if (distributor() == 'goma' and platform() == 'win32' and 29 if (distributor() == 'goma' and platform() == 'win32' and
30 builder() == 'ninja'): 30 builder() == 'ninja'):
31 print 'Need to clobber winja goma due to backend cwd cache fix.' 31 print 'Need to clobber winja goma due to backend cwd cache fix.'
32 if platform() == 'android': 32 if platform() == 'android':
33 print 'Clobber: To avoid unresolved link errors on Breakpad roll.' 33 print 'Clobber: To delete generated class files (we just use jars now).'
34 print 'Clobber: To get rid of generated files in the wrong package.'
35 if platform() == 'win' and builder() == 'ninja': 34 if platform() == 'win' and builder() == 'ninja':
36 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 35 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
37 if platform() == 'linux' and builder() == 'ninja': 36 if platform() == 'linux' and builder() == 'ninja':
38 print 'Builders switching from make to ninja will clobber on this.' 37 print 'Builders switching from make to ninja will clobber on this.'
39 if platform() == 'mac': 38 if platform() == 'mac':
40 print 'Switching from bundle to unbundled dylib (issue 14743002).' 39 print 'Switching from bundle to unbundled dylib (issue 14743002).'
41 if platform() in ('win', 'mac'): 40 if platform() in ('win', 'mac'):
42 print ('Improper dependency for create_nmf.py broke in r240802, ' 41 print ('Improper dependency for create_nmf.py broke in r240802, '
43 'fixed in r240860.') 42 'fixed in r240860.')
44 if (platform() == 'win' and builder() == 'ninja' and 43 if (platform() == 'win' and builder() == 'ninja' and
(...skipping 24 matching lines...) Expand all
69 68
70 if args: 69 if args:
71 parser.error('Unknown arguments %s' % args) 70 parser.error('Unknown arguments %s' % args)
72 71
73 print_landmines(options.target) 72 print_landmines(options.target)
74 return 0 73 return 0
75 74
76 75
77 if __name__ == '__main__': 76 if __name__ == '__main__':
78 sys.exit(main()) 77 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/pylib/utils/findbugs.py ('k') | build/java.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698