Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

Issue 458643003: Remove serial test support from test-webkitpy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove flaky error code check in all cases Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/common/system/executive_unittest.py ('k') | Tools/Scripts/webkitpy/test/main.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
index 01761c78cfb9bfa0590a9f71c220051cc55a65ab..c4052dbd9029d19bab79111533f6ad07a1b79f9f 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
@@ -123,13 +123,6 @@ class AndroidCommandsTest(unittest.TestCase):
def make_android_commands(self, device_count, serial):
return android.AndroidCommands(self.make_executive(device_count), serial, debug_logging=False)
- # The "adb" binary with the latest version should be used.
- def serial_test_adb_command_path(self):
- executive = self.make_executive(0)
-
- android.AndroidCommands.set_adb_command_path_options(['path1', 'path2', 'path3'])
- self.assertEqual('path2', android.AndroidCommands.adb_command_path(executive, debug_logging=False))
-
# The used adb command should include the device's serial number, and get_serial() should reflect this.
def test_adb_command_and_get_serial(self):
android_commands = self.make_android_commands(1, '123456789ABCDEF0')
« no previous file with comments | « Tools/Scripts/webkitpy/common/system/executive_unittest.py ('k') | Tools/Scripts/webkitpy/test/main.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698