Remove serial test support from test-webkitpy.

Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

 # Copyright (C) 2012 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #    * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #    * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 105 matching lines @@
         android.AndroidCommands._adb_command_path = None
         android.AndroidCommands._adb_command_path_options = ['adb']
 
     def make_executive(self, device_count):
         self._mock_executive = MockAndroidDebugBridge(device_count)
         return MockExecutive2(run_command_fn=self._mock_executive.run_command)
 
     def make_android_commands(self, device_count, serial):
         return android.AndroidCommands(self.make_executive(device_count), serial, debug_logging=False)
 
-    # The "adb" binary with the latest version should be used.
-    def serial_test_adb_command_path(self):

[Dirk Pranke, 2014/08/09 00:00:11]

This test has unpleasant side effects and is testing a code path that

a) is already covered any time we create an AndroidCommands() object

b) shouldn't exist at all (using a static mutable value to cache the path to adb
is just wrong)

c) was originally intended to look for adb in multiple places, which we don't
actually use now.

At some point I'll clean up the other code, but this test does more harm than
good.

-        executive = self.make_executive(0)
-
-        android.AndroidCommands.set_adb_command_path_options(['path1', 'path2', 'path3'])
-        self.assertEqual('path2', android.AndroidCommands.adb_command_path(executive, debug_logging=False))
-
     # The used adb command should include the device's serial number, and get_serial() should reflect this.
     def test_adb_command_and_get_serial(self):
         android_commands = self.make_android_commands(1, '123456789ABCDEF0')
         self.assertEquals(['adb', '-s', '123456789ABCDEF0'], android_commands.adb_command())
         self.assertEquals('123456789ABCDEF0', android_commands.get_serial())
 
     # Running an adb command should return the command's output.
     def test_run_command(self):
         android_commands = self.make_android_commands(1, '123456789ABCDEF0')
 
@@ skipping 175 matching lines @@
     # Tests that valid tombstone listings will return the contents of the most recent file.
     def test_read_valid_tombstone_file(self):
         self._mock_adb.set_tombstone_output('-rw------- 1000 1000 3604 2013-11-19 16:15 tombstone_00\n' +
                                             '-rw------- 1000 1000 3604 2013-11-19 16:16 tombstone_10\n' +
                                             '-rw------- 1000 1000 3604 2013-11-19 16:15 tombstone_02')
         stacktrace = self._driver._get_last_stacktrace()
 
         self.assertEqual(0, len(self._warnings))
         self.assertEqual(0, len(self._errors))
         self.assertEqual(ChromiumAndroidDriverTombstoneTest.EXPECTED_STACKTRACE, stacktrace)