Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 458643002: [Docs] device mode in devtools docs topnav (Closed)

Created:
6 years, 4 months ago by paulirish
Modified:
6 years, 4 months ago
CC:
pearlchen
Base URL:
https://chromium.googlesource.com/chromium/src@master
Visibility:
Public.

Description

[Docs] device mode in devtools docs topnav BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
paulirish
6 years, 4 months ago (2014-08-08 23:32:10 UTC) #1
mkearney1
lgtm with a request to see a staged version to double-check.
6 years, 4 months ago (2014-08-18 18:39:56 UTC) #2
paulirish
This is due to docserver preview script not understanding my clone of the git repo. ...
6 years, 4 months ago (2014-08-19 19:33:03 UTC) #3
paulirish
The CQ bit was checked by paulirish@chromium.org
6 years, 4 months ago (2014-08-19 19:33:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/458643002/1
6 years, 4 months ago (2014-08-19 19:34:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 19:34:37 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-19 19:34:38 UTC) #7
paulirish
@kalman, I need a rubberstamp on this baby.
6 years, 4 months ago (2014-08-19 20:02:01 UTC) #8
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-19 20:03:33 UTC) #9
paulirish1
The CQ bit was checked by paulirish@google.com
6 years, 4 months ago (2014-08-19 20:28:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/458643002/1
6 years, 4 months ago (2014-08-19 20:29:51 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 02:59:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 290737

Powered by Google App Engine
This is Rietveld 408576698