components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java - Issue 458633002: Merge UrlRequest.java into ChromiumUrlRequest.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

Issue 458633002: Merge UrlRequest.java into ChromiumUrlRequest.java (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address clm's comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java ('K') | « components/cronet/android/org_chromium_net_UrlRequest_priority_list.h ('k') | components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

diff --git a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

index 860237612df1ca05b68068b32ffff82b8d0800a0..aef180500f480ae5bf9770b4305581bec06d176d 100644

--- a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

+++ b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

@@ -78,10 +78,11 @@ public class CronetSampleUrlTest extends CronetSampleTestBase {

waitForActiveShellToBeDoneLoading();

File file = File.createTempFile("cronet", "json");

- activity.mRequestContext.startNetLogToFile(file.getPath());

- activity.startWithURL_UrlRequest(URL);

+ activity.mChromiumRequestFactory.getRequestContext().startNetLogToFile(

+ file.getPath());

+ activity.startWithURL(URL);

Thread.sleep(5000);

- activity.mRequestContext.stopNetLog();

+ activity.mChromiumRequestFactory.getRequestContext().stopNetLog();

assertTrue(file.exists());

assertTrue(file.length() != 0);

assertTrue(file.delete());