Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 458543002: Update path to Android font config file (Closed)

Created:
6 years, 4 months ago by Tom Hudson
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update path to Android font config file In version LMP, Android is expected to change the path to their font configuration file (and condense several files into one), as well as changing the format (qv http://crrev.com/446473003/). This patch tries the new path before falling back to the old path. The new fonts are incompatible with assumptions made by the old SkFontConfigInterfaceAndroid, so this patch MUST NOT land until https://crrev.com/462073002/ or the equivalent has turned on the new SkFontManager. BUG=chromium:400801 R=djsollen@google.com,bungeman@google.com Committed: https://skia.googlesource.com/skia/+/94fa4b99e2a53e997a90c7808cc5263f1bf40c9f Committed: https://skia.googlesource.com/skia/+/7a4747f4f62e4896d8f8469e1939b8191fff8d4e

Patch Set 1 #

Patch Set 2 : Fix branch background #

Patch Set 3 : Track Android path changes #

Patch Set 4 : Bugfix to lowercase #

Patch Set 5 : Move lower-case fix to a different patch #

Total comments: 2

Patch Set 6 : Derek's late review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/ports/SkFontConfigParser_android.cpp View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tomhudson
Dag-nabbit, this picked up another CL on the wrong branch. Only intended change is the ...
6 years, 4 months ago (2014-08-08 19:35:26 UTC) #1
tomhudson
Confirmed with Raph that he really did mean to put the XML in /system/etc, not ...
6 years, 4 months ago (2014-08-11 20:59:33 UTC) #2
tomhudson
While testing with SK_FONTHOST_DOES_NOT_USE_FONTMGR removed, unit tests pointed out I'd left SkAutoAsciiToLC out of the ...
6 years, 4 months ago (2014-08-11 21:45:13 UTC) #3
bungeman-skia
lgtm
6 years, 4 months ago (2014-08-12 17:54:18 UTC) #4
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-08-12 17:58:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/458543002/80001
6 years, 4 months ago (2014-08-12 17:58:17 UTC) #6
commit-bot: I haz the power
Change committed as 94fa4b99e2a53e997a90c7808cc5263f1bf40c9f
6 years, 4 months ago (2014-08-12 18:05:40 UTC) #7
djsollen
late comments. https://codereview.chromium.org/458543002/diff/80001/src/ports/SkFontConfigParser_android.cpp File src/ports/SkFontConfigParser_android.cpp (right): https://codereview.chromium.org/458543002/diff/80001/src/ports/SkFontConfigParser_android.cpp#newcode22 src/ports/SkFontConfigParser_android.cpp:22: // /system/fonts/fonts.xml. Instead of trying to detect ...
6 years, 4 months ago (2014-08-13 13:31:53 UTC) #8
tomhudson
Derek - thanks for the additional review; patch 6 should have addressed your two comments.
6 years, 4 months ago (2014-08-13 17:55:13 UTC) #9
djsollen
PS6 lgtm
6 years, 4 months ago (2014-08-13 17:56:47 UTC) #10
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-08-13 17:57:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/458543002/100001
6 years, 4 months ago (2014-08-13 17:58:26 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 18:06:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 (100001) as 7a4747f4f62e4896d8f8469e1939b8191fff8d4e

Powered by Google App Engine
This is Rietveld 408576698