src/objects.cc - Issue 458533002: Fix disassembly redirection from stdout into a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 458533002: Fix disassembly redirection from stdout into a file. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 645bb4a74e39f81272c0c9e3c4c4d913976224fc..eb41c48a2963776f207763afd076a6cd78dc4fbd 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -11388,7 +11388,10 @@ void Code::Disassemble(const char* name, OStream& os) { // NOLINT

os << "Instructions (size = " << instruction_size() << ")\n";

// TODO(svenpanne) The Disassembler should use streams, too!

- Disassembler::Decode(stdout, this);

+ {

+ CodeTracer::Scope trace_scope(GetIsolate()->GetCodeTracer());

+ Disassembler::Decode(trace_scope.file(), this);

+ }

os << "\n";

if (kind() == FUNCTION) {

« no previous file with comments | « no previous file | src/ostreams.cc » ('j') | src/ostreams.cc » ('J')