Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 458523002: Moves analyze config into its own file (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Moves analyze config into its own file This way I don't have to duplicate it across bots. BUG=109173 TEST=none R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288809

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge 2 trunk #

Total comments: 2

Patch Set 4 : %r #

Patch Set 5 : merge 2 trunk #

Messages

Total messages: 6 (0 generated)
sky
6 years, 4 months ago (2014-08-08 17:40:47 UTC) #1
iannucci
lgtm https://codereview.chromium.org/458523002/diff/40001/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/458523002/diff/40001/scripts/slave/recipes/chromium_trybot.py#newcode452 scripts/slave/recipes/chromium_trybot.py:452: step_result.presentation.step_text = 'path: %s' % config_path you may ...
6 years, 4 months ago (2014-08-09 02:23:03 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-11 22:20:48 UTC) #3
sky
https://codereview.chromium.org/458523002/diff/40001/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/458523002/diff/40001/scripts/slave/recipes/chromium_trybot.py#newcode452 scripts/slave/recipes/chromium_trybot.py:452: step_result.presentation.step_text = 'path: %s' % config_path On 2014/08/09 02:23:03, ...
6 years, 4 months ago (2014-08-11 22:20:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/458523002/80001
6 years, 4 months ago (2014-08-11 22:21:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 22:23:13 UTC) #6
Message was sent while issue was closed.
Change committed as 288809

Powered by Google App Engine
This is Rietveld 408576698